Block Editor: Fix padding appender last block focus #72821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: 0 B Total Size: 2.37 MB ℹ️ View Unchanged
|
6 tasks
stokesman
approved these changes
Oct 30, 2025
Contributor
stokesman
left a comment
stokesman
left a comment
There was a problem hiding this comment.
Looks good and works well for me. It’s great to see the e2e test update.
I think pointerdown may make more sense for the part this fixes (since focus moves on pointerdown, not click). I’d question whether the insertion should still be limited to click but I wouldn’t say it must be.
If this isn’t backported for 6.9 but it ends up that #72598 is (in support of #72547) then I think we’ll have to remember to reapply this 🤔. I have a couple of fixes for more obscure issues with the padding appender that I'm waiting to suggest cause of the same consideration.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
the
Backport to WP 6.9 Beta/RC
Member
Author
|
Thanks for the review, @stokesman! I think this is safe to backport; it's a minor change for a fix, and it also improves the behavior of Notes. |
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 31, 2025
* Add failing e2e test for the bug * Fix the padding appender bug Co-authored-by: Mamaduka <[email protected]> Co-authored-by: stokesman <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 128cddc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Possible regression after #66402.
PR tries to fix a regression where focus isn't transferred to the last default block in the canvas when clicking "padding appender".
How?
Switch to the
pointerdownevent inusePaddingAppender, so that it can correctly prevent default behavior forpreventFocusCapture.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2025-10-30.at.11.12.11.mp4