Skip to content

Conversation

@joshualip-plaudit
Copy link
Contributor

What?

Closes #72806

Fixes the exports field of the package.json file so that TypeScript can resolve its typedefs again.

Why?

TypeScript cannot currently resolve the plugin's typedefs

How?

I added the typedefs to the exports field of the plugin's package.json file

Testing Instructions

  1. Make a TypeScript project using the Node16 moduleResolution mode
  2. Try to import: import DependencyExtractionWebpackPlugin from "@wordpress/dependency-extraction-webpack-plugin";
  3. Run tsc
  4. If you didn't get an error, then it's fixed

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: joshualip-plaudit <[email protected]>
Co-authored-by: manzoorwanijk <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@joshualip-plaudit
Copy link
Contributor Author

I did a force-push to fix the author stuff, but I cannot add the necessary label to get it to reload the list.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Tool] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin labels Oct 31, 2025
Copy link
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thank you for the fix.

@manzoorwanijk manzoorwanijk enabled auto-merge (squash) November 3, 2025 17:00
@manzoorwanijk manzoorwanijk merged commit d5973d8 into WordPress:trunk Nov 3, 2025
34 checks passed
@github-actions github-actions bot added this to the Gutenberg 22.1 milestone Nov 3, 2025
@joshualip-plaudit joshualip-plaudit deleted the patch-1 branch November 3, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Tool] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@wordpress/dependency-extraction-webpack-plugin typedefs aren't resolved under Node16

3 participants