Conversation
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| * @package Gutenberg | ||
| */ | ||
| class WP_Test_REST_Comments_Controller_Gutenberg extends WP_Test_REST_Controller_Testcase { | ||
| class WP_Test_REST_Comments_Controller_Gutenberg extends WP_Test_REST_TestCase { |
There was a problem hiding this comment.
Changed this back to WP_Test_REST_TestCase. The controller testcase has a couple of abstract methods that we don't need for testing.
| self::$user_ids = array( | ||
| 'administrator' => self::$admin_id, | ||
| 'editor' => self::$editor_id, | ||
| 'contributor' => self::$contributor_id, | ||
| 'subscriber' => self::$subscriber_id, | ||
| 'author' => self::$author_id, | ||
| ); |
There was a problem hiding this comment.
This map was missing and failing tests.
|
Flaky tests detected in 29c3d8a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18907863337
|
|
Thanks, @adamsilverstein! Going to merge this. |
2 participants
What?
Noticed while testing WordPress/wordpress-develop#10430.
The PHPUnit tests weren't running after changes were backported from core. The test files in this repo require a
-test.phpsuffix.Testing Instructions