The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: adamsilverstein <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Size Change: -281 B (-0.01%)

Total Size: 2.37 MB

_{compressed-size-action}

Well done, looks good, ship it.

A question for some time in the future, do we already now have in place a system for handling "avatar overflow" in the toolbar? The design we have for it is this:

That is, 1, 2, 3 at most, if there are more than 3 comments, show 2 avatars and a "+n" number.

Thanks for sharing the design specs, @jasmussen!

It looks like we're doing z-indexing in the opposite way. The limit is also 3 participants, and +n has a background.

This is how overflow looks on this branch with more participants.

Flaky tests detected in b733437.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18910405609
📝 Reported issues:

• [Flaky Test] should refresh the page when stylesheet loading fails #71722 in /test/e2e/specs/interactivity/router-styles.spec.ts

Thanks for the screenshot. I'm not sure the backdrop and backdrop color around the white number helps, I'd just make that plain text, and I'd reduce to 2 avatars max as space is at a premium in the block toolbar. But not sure if that can be fixed as a bug in this phase or not, so I'm happy to open an issue to track it for a later time. What do you think?

But not sure if that can be fixed as a bug in this phase or not, so I'm happy to open an issue to track it for a later time. What do you think?

I think it's okay to ship those fixes alongside the changes here. @t-hamano, what do you think?

I think it's okay to ship those fixes alongside the changes here

It seems fine to me - the bug is "Avatars don't match design spec"

I see, I will try to revise the design as much as possible in this pull request.

I've updated it as much as possible based on the design. Please check the new screenshots attached to this comment.

Looks more or less perfect to me, thanks so much. What do you all think?

Looks good ✅

I think we still need to fix the display when "Show button text labels" is enabled, but that's a different issue.

Screenshot

Thank you everyone for your reviews!

I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 1346ddb