Notes: Prevent 403 error for low capability users #72767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +35 B (0%) Total Size: 2.37 MB
ℹ️ View Unchanged
|
Mamaduka
commented
Oct 29, 2025
Comment on lines
+47
to
+48
| const { __experimentalDiscussionSettings } = getSettings(); | ||
| const defaultAvatar = __experimentalDiscussionSettings?.avatarURL; |
Member
Author
There was a problem hiding this comment.
Maybe we should just use a static fallback avatar here, an SVG or something.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
approved these changes
Oct 29, 2025
Member
Author
|
Thanks for the review, @t-hamano! |
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 29, 2025
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: f7141a1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates the
CommentAuthorInfocomponent to avoid403error when trying to fetch site settings for lower capability users.I've also added an early return when the component already receives user data. There's no need to select fallbacks in this case. This also reduces the number of
block-editorstore subscriptions created per note.Testing Instructions
403 Forbiddenerror is logged.Testing Instructions for Keyboard
Same.
Screenshots or screencast