Build: Support third-party plugin scripts properly #72760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Build Tooling
|
Size Change: 0 B Total Size: 2.37 MB ℹ️ View Unchanged
|
Member
|
Something I'd love to be able to do with this build tool and custom package namespaces is also doing the dependency extraction. (I want to be able to add my own custom mapping for externalized packages) Woo for example has The key here is that it should be something that can work across multiple packages. I may have one plugin that references packages from another plugin. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
This is what this PR allows for your own plugin, but I guess we can also add a config for additional plugins like say : |
Member
Yeah this is what I was trying to say but didn't quite find the words for it 😂
This would be perfect 👍 |
Contributor
Author
|
@fabiankaegy Added :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #72032
What?
This PR adds custom namespace support to
@wordpress/build, allowing third-party plugins to expose their own global variables (e.g.,window.myPlugin.*) instead of being restricted to thewp.*. It also allows disabling global generation.Why?
Currently,
@wordpress/buildis hardcoded to use thewpnamespace for all packages. This limits third-party plugins that want to:How?
wpPlugin.scriptGlobalandwpPlugin.packageNamespaceconfiguration to rootpackage.jsonbuild.mjsto conditionally setglobalNamebased on package namespace matchingwordpress-externals-plugin.mjsto use unified configuration for both WordPress and custom namespacesConfiguration example:
{ "wpPlugin": { "scriptGlobal": "myPlugin", "packageNamespace": "my-plugin" } }Behavior:
Testing Instructions