Theme: Add Storybook stories #72747
Merged
Theme: Add Storybook stories #72747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Developer Documentation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
commented
Oct 28, 2025
Comment on lines
-198
to
+200
| DEFAULT_SEED_COLORS.bg; | ||
| DEFAULT_SEED_COLORS.primary; | ||
| const bg = | ||
| color.bg ?? inheritedSettings.color?.bg ?? DEFAULT_SEED_COLORS.primary; | ||
| color.bg ?? inheritedSettings.color?.bg ?? DEFAULT_SEED_COLORS.bg; |
Member
Author
There was a problem hiding this comment.
This is a bug in the implementation. Evidenced by the other variables it's pulling from and the name of the variables being assigned, these were wrongly inverted.
|
Size Change: 0 B Total Size: 2.37 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 676665d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18887284590
|
mirka
approved these changes
Oct 28, 2025
storybook/main.js
Outdated
| '../packages/global-styles-ui/src/**/stories/*.story.@(js|tsx|mdx)', | ||
| '../packages/dataviews/src/**/stories/*.story.@(js|tsx|mdx)', | ||
| '../packages/fields/src/**/stories/*.story.@(js|tsx|mdx)', | ||
| '../packages/theme/src/**/*.stories.@(tsx|mdx)', |
Member
There was a problem hiding this comment.
Let's change the naming convention of the story files to match the other packages. **/stories/*.story.@ instead of **/*.stories.@.
For example there's also a loader here that expects that naming convention, and maybe some other stuff too. It'll be simpler to stick with a single pattern.
Member
Author
There was a problem hiding this comment.
Let's change the naming convention of the story files to match the other packages.
**/stories/*.story.@instead of**/*.stories.@.
👍 Updated in 2266c4f.
| */ | ||
| import { ThemeProvider } from './theme-provider'; | ||
|
|
||
| const meta: Meta< typeof ThemeProvider > = { |
Member
There was a problem hiding this comment.
No strong opinion on whether it needs to be added now, but I'll note that this is technically missing the stylesheet. If we were to add it, they're managed here.
Member
Author
Member
Author
There was a problem hiding this comment.
To expand a bit, I'm also assuming we won't need separate LTR and RTL stylesheets because we intend to use logical properties exclusively, though I can also clarify this with an inline comment, and follow-up with more strict enforcement.
Member
Author
There was a problem hiding this comment.
I can also clarify this with an inline comment
Added in 676665d
Member
Author
There was a problem hiding this comment.
follow-up with more strict enforcement.
Follow-up at #72758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds Storybook stories for the
themepackage added in #72305Follow-up to #72305
Why?
This was a follow-up action noted in #72305
Storybook stories help provide visibility to this work, and will be important to demonstrate changes to the theme implementation.
Testing Instructions
Verify Storybook stories demonstrate theme functionality:
npm run storybook:dev