-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Notes: Update delete confirmation message #72737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note: we'll need to land this before the hard string breeze. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +19 B (0%) Total Size: 2.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 74fdcdd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18865466597
|
juanfra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
t-hamano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: iqbal-web <[email protected]> Co-authored-by: juanfra <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: desrosj <[email protected]>
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 8e47792 |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
What?
Closes #72722
PR updates text copy for note delete confirmation message, to inform users that deleting a parent note also deletes all its replies.
Why?
See #72722.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast