Template activation: fix undefined array key PHP warning #72729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
Backport to WP 6.9 Beta/RC
ellatrix
force-pushed
the
fix/template-activation-undefined-array-key
branch
from
d27e2f5 to
e39f21d
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 9c900ee. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18902483125
|
Mamaduka
reviewed
Oct 28, 2025
| $object = get_queried_object(); | ||
| $specific_template = $object ? get_page_template_slug( $object ) : null; | ||
| $object_id = get_queried_object_id(); | ||
| $specific_template = $object_id && get_post( $object_id ) ? get_page_template_slug( $object_id ) : null; |
Member
There was a problem hiding this comment.
Suggested change
| $specific_template = $object_id && get_post( $object_id ) ? get_page_template_slug( $object_id ) : null; | |
| $specific_template = $object_id ? get_page_template_slug( $object_id ) : null; |
The get_page_template_slug also performs a get_post check and bails early. See: https://developer.wordpress.org/reference/functions/get_page_template_slug/
Member
Author
There was a problem hiding this comment.
Oh nice. Perhaps safer to pass an ID instead of a whole queried object though?
Member
There was a problem hiding this comment.
Yes. ID is probably safer in this case
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Oct 28, 2025
Developed in #10425. See https://core.trac.wordpress.org/ticket/62755. * Rename new endpoints, WordPress/gutenberg#72700. * Remove fake post type for registered templates, WordPress/gutenberg#72674. * Remove the ability to deactivate registered templates, WordPress/gutenberg#72636, * Fix undefined array key PHP warning, WordPress/gutenberg#72729. * Add migration logic (to be refined), see https://core.trac.wordpress.org/ticket/64133 and #10418. Fixes #62755. Props ellatrix, priethor. git-svn-id: https://develop.svn.wordpress.org/trunk@61078 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Oct 28, 2025
Developed in WordPress/wordpress-develop#10425. See https://core.trac.wordpress.org/ticket/62755. * Rename new endpoints, WordPress/gutenberg#72700. * Remove fake post type for registered templates, WordPress/gutenberg#72674. * Remove the ability to deactivate registered templates, WordPress/gutenberg#72636, * Fix undefined array key PHP warning, WordPress/gutenberg#72729. * Add migration logic (to be refined), see https://core.trac.wordpress.org/ticket/64133 and WordPress/wordpress-develop#10418. Fixes #62755. Props ellatrix, priethor. Built from https://develop.svn.wordpress.org/trunk@61078 git-svn-id: http://core.svn.wordpress.org/trunk@60414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Oct 28, 2025
Developed in WordPress/wordpress-develop#10425. See https://core.trac.wordpress.org/ticket/62755. * Rename new endpoints, WordPress/gutenberg#72700. * Remove fake post type for registered templates, WordPress/gutenberg#72674. * Remove the ability to deactivate registered templates, WordPress/gutenberg#72636, * Fix undefined array key PHP warning, WordPress/gutenberg#72729. * Add migration logic (to be refined), see https://core.trac.wordpress.org/ticket/64133 and WordPress/wordpress-develop#10418. Fixes #62755. Props ellatrix, priethor. Built from https://develop.svn.wordpress.org/trunk@61078 git-svn-id: https://core.svn.wordpress.org/trunk@60414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
ellatrix
force-pushed
the
fix/template-activation-undefined-array-key
branch
from
e39f21d to
9c900ee
Compare
Mamaduka
approved these changes
Oct 29, 2025
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 29, 2025
Co-authored-by: ellatrix <[email protected]> Co-authored-by: Mamaduka <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 0bf76a7 |
bph
added
the
[Feature] Templates API
ellatrix
added a commit
that referenced
this pull request
Nov 5, 2025
)" This reverts commit 0bf76a7.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes https://core.trac.wordpress.org/ticket/62755#comment:11
get_queried_objectdoes not return a post. We should double check that it's a post before getting the slug. This doesn't actually fix anything, but it would be good practice.Why?
Avoid PHP warnings.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast