-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Template activation: redirect to 'Create Templates' after duplication #72727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +77 B (0%) Total Size: 2.37 MB
ℹ️ View Unchanged
|
7481e98 to
56462f9
Compare
|
Flaky tests detected in 1204fd1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18902996188
|
mcsf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement!
| ]; | ||
| if ( activeView === 'user' ) { | ||
| _fields.push( themeField ); | ||
| if ( dateField ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to ask if there's any context to keep in mind here: when is dateField not found? We're looking at only one post type (wp_template).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be loading (usePostActions depends on getEntityActions)
|
Thanks @mcsf! |
…#72727) Co-authored-by: ellatrix <[email protected]> Co-authored-by: mcsf <[email protected]>
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 76842c4 |
|
I just cherry-picked this PR to the release/22.0 branch to get it included in the next release: bc5239e |
…#72727) Co-authored-by: ellatrix <[email protected]> Co-authored-by: mcsf <[email protected]>
What?
Closes #72587
When duplicating a template, redirect to the "created templates" tab. Additionally, we should sort the "created templates" (aka database templates) by date by default (just like normal posts) so that the newly created/duplicated templates shows first.
Why?
Because you will not be able to find it in the theme or active templates tab.
How?
Testing Instructions
Go to the theme templates or active templates tab. Use the data view action to duplicate a template. You should land in the "created templates" tab. Perhaps in the future we should sort them by date so that it's the first template in the list.
Testing Instructions for Keyboard
Screenshots or screencast