Block Bindings: Remove editorUI and modal versions. #72723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Code Quality
|
Size Change: -707 B (-0.03%) Total Size: 2.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5853f83. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18851584386
|
cbravobernal
commented
Oct 27, 2025
cbravobernal
requested review from
ajitbohra,
ellatrix,
nerrad,
ntwb and
tellthemachines
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
cbravobernal
added
the
Backport to WP 6.9 Beta/RC
ockham
approved these changes
Oct 28, 2025
Contributor
ockham
left a comment
ockham
left a comment
There was a problem hiding this comment.
Thank you, great work on a pretty tight timeline! 🌟
LGTM, and works well in my testing!
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 28, 2025
Co-authored-by: cbravobernal <[email protected]> Co-authored-by: ockham <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 9ba768d |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
After some testing and consideration, the API is not ready to provide a modal UI.
This is mainly due to a possible incompatibility with the upcoming Pattern Editing and contentOnly mode (#71517
). External third-party developers might use the modal version to build their own content editing workflows, which may need to be updated after future iterations of this mode.
There might come a time when users leverage patterns and the Site Editor to connect block attributes with sources, using the contentOnly mode just to update those source data.
Therefore, the least risky action is to remove the modal approach.
Removing the modal implies that editorUI no longer makes sense, as it was only a wrapper for two modes and the data provided by the
getFieldsListfunction.getFieldsListhas been around for a year, so a better approach is to update the dropdown mode to be a UI that first displays a list of different sources, allowing navigation into them and adding new ones to Core when needed. For now, we’ll continue relying on thegetFieldsListfunction until different UIs (Data Views, Admin, Fields API, etc.) evolve in future iterations.