Skip to content

Breadcrumbs: Add 404, search and paged support for archives #72714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ntsekouras merged 2 commits into from
Oct 30, 2025
Merged

Breadcrumbs: Add 404, search and paged support for archives #72714

ntsekouras merged 2 commits into from
Oct 30, 2025

Conversation

@ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras commented Oct 27, 2025 •
edited
Loading

What?

Part of: #72498

This PR does 3 things:

  1. Adds 404 support Home / 404 Not Found
  2. Search support Home / Search results for: "a"
  3. Adds pagination support for archive templates (author, taxonomies, post type, date) and search. Pagination results appear like this: Home / Books / Page 2.

Testing Instructions

  1. Enable GB experimental blocks.
  2. For easier testing I'm adding this plugin and the core block in theme's header and test various pages in the front end.
  3. Test 404
  4. Test searching something
  5. For testing pagination it's easier if you set the number of posts to one in reading settings. Then test archive templates (author, taxonomies, post type, date) and search, by going to the next page

Sample screenshots

Screenshot 2025-10-27 at 5 16 16 PM Screenshot 2025-10-27 at 5 16 34 PM Screenshot 2025-10-27 at 5 16 42 PM

@ntsekouras ntsekouras self-assigned this Oct 27, 2025
@ntsekouras ntsekouras added [Type] Enhancement A suggestion for improvement. [Block] Breadcrumbs (experimental) Affects the Breadcrumbs Block labels Oct 27, 2025
@github-actions
Copy link

github-actions bot commented Oct 27, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <[email protected]>
Co-authored-by: jorgefilipecosta <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ntsekouras ntsekouras force-pushed the breadcrumbs/add-archive-paged-support-404-search branch from 3678ad7 to 19ad6f1 Compare October 27, 2025 15:24
@github-actions
Copy link

github-actions bot commented Oct 27, 2025 •
edited
Loading

Flaky tests detected in 85df173.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18933161350
📝 Reported issues:

@jorgefilipecosta jorgefilipecosta self-requested a review October 29, 2025 09:10
jorgefilipecosta
jorgefilipecosta reviewed Oct 29, 2025
View reviewed changes
jorgefilipecosta
jorgefilipecosta approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested search, paginated search, 404, paginated categories, paginated archives, and the 404, everything worked well, and the code looks good 👍

@ntsekouras ntsekouras force-pushed the breadcrumbs/add-archive-paged-support-404-search branch from 19ad6f1 to 85df173 Compare October 30, 2025 07:28
@ntsekouras ntsekouras enabled auto-merge (squash) October 30, 2025 07:28
@ntsekouras ntsekouras merged commit e0501d4 into trunk Oct 30, 2025
33 checks passed
@ntsekouras ntsekouras deleted the breadcrumbs/add-archive-paged-support-404-search branch October 30, 2025 08:04
@github-actions github-actions bot added this to the Gutenberg 22.1 milestone Oct 30, 2025
tyxla
tyxla reviewed Oct 31, 2025
View reviewed changes
@ntsekouras ntsekouras mentioned this pull request Oct 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tyxla tyxla tyxla left review comments

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@mcsf mcsf Awaiting requested review from mcsf

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

@justintadlock justintadlock Awaiting requested review from justintadlock

@t-hamano t-hamano Awaiting requested review from t-hamano

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@ntsekouras ntsekouras

Labels

[Block] Breadcrumbs (experimental) Affects the Breadcrumbs Block [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 22.1

Development

Successfully merging this pull request may close these issues.

4 participants

@ntsekouras @tyxla @jorgefilipecosta