Skip to content

Breadcrumbs: Fix date archives with plain permalinks #72709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ntsekouras merged 2 commits into from
Oct 29, 2025
Merged

Breadcrumbs: Fix date archives with plain permalinks #72709

ntsekouras merged 2 commits into from
Oct 29, 2025

Conversation

@ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras commented Oct 27, 2025

What?

I observed that with plain permalinks the date-archives breadcrumbs didn't work. This is because plain permalinks use ?m=YYYYMMDD format instead of separate query vars. This PR fixes that by also checking m similarly with single_month_title in core.

Testing Instructions

  1. Test breadcrumbs in date archive pages with both pretty and plain permalinks
  2. Observe that they work as expected.

@ntsekouras ntsekouras self-assigned this Oct 27, 2025
@ntsekouras ntsekouras added [Type] Bug An existing feature does not function as intended [Block] Breadcrumbs (experimental) Affects the Breadcrumbs Block labels Oct 27, 2025
@github-actions
Copy link

github-actions bot commented Oct 27, 2025

Flaky tests detected in c5a3b00.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18843883600
📝 Reported issues:

@github-actions
Copy link

github-actions bot commented Oct 27, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <[email protected]>
Co-authored-by: iqbal-web <[email protected]>
Co-authored-by: jorgefilipecosta <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

jorgefilipecosta
jorgefilipecosta reviewed Oct 29, 2025
View reviewed changes
@ntsekouras ntsekouras force-pushed the breadcrumbs/fix-date-archives-with-plain-permalinks branch from c5a3b00 to 24afc54 Compare October 29, 2025 07:57
jorgefilipecosta
jorgefilipecosta approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened an archive at http://localhost:6888/site-wp-dev-3/?m=20251029, tried the breadcrumbs block everything worked as expected, I could correctly navigate to the month and year archives, and inside each things also worked.

@ntsekouras ntsekouras enabled auto-merge (squash) October 29, 2025 08:11
@ntsekouras ntsekouras merged commit aec59ba into trunk Oct 29, 2025
36 checks passed
@ntsekouras ntsekouras deleted the breadcrumbs/fix-date-archives-with-plain-permalinks branch October 29, 2025 08:33
@github-actions github-actions bot added this to the Gutenberg 22.0 milestone Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@mcsf mcsf Awaiting requested review from mcsf

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

@t-hamano t-hamano Awaiting requested review from t-hamano

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

+1 more reviewer

@iqbal-web iqbal-web iqbal-web approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ntsekouras ntsekouras

Labels

[Block] Breadcrumbs (experimental) Affects the Breadcrumbs Block [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 22.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ntsekouras @jorgefilipecosta @iqbal-web