Accordion: Dont' show Add button in contentOnly mode #72704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
@talldan @tellthemachines Can you share a little more context about why we decided to not ship this in 6.9? Given how it was working before 🤔 It would be such a massive win to have this present |
fabiankaegy
approved these changes
Oct 27, 2025
Member
fabiankaegy
left a comment
fabiankaegy
left a comment
There was a problem hiding this comment.
If we really need to do it this works and is approved to merge.
But I'd love it to not be needed by allowing the insertion again 😬
|
Size Change: -3 B (0%) Total Size: 2.37 MB
ℹ️ View Unchanged
|
Contributor
Author
|
@fabiankaegy Thanks for the review! It would be ideal if we could enable the previous functionality, but for now, this button is not working, so let's merge this pull request. |
|
Flaky tests detected in 94698a3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18841468296
|
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 27, 2025
Co-authored-by: t-hamano <[email protected]> Co-authored-by: fabiankaegy <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 22d3371 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As I understand it, in the 6.9 release, blocks with a
contentRolesupport can no longer add new items in contentOnly mode.Accordingly, I'd like to hide the Add button when in contentOnly mode.
Why?
Because nothing happens when the button is pressed.
Testing Instructions
Insert blocks using the following HTML:
Screenshots or screencast