Command Palette: Disable site editor navigation commands on Network Admin - Take 2#72698
Merged
Command Palette: Disable site editor navigation commands on Network Admin - Take 2#72698
Conversation
t-hamano
added
[Type] Bug
t-hamano
changed the title
|
Size Change: -27 B (0%) Total Size: 2.37 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
approved these changes
Oct 27, 2025
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
This seems way more reliable. Thanks!
Contributor
Author
|
@ntsekouras Thanks for the review! |
|
Flaky tests detected in 22f2eaa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18902807045
|
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 29, 2025
…dmin - Take 2 (#72698) * Command Palette: Disable site editor navigation commands on Network Admin * Add backport changelog Co-authored-by: t-hamano <[email protected]> Co-authored-by: ntsekouras <[email protected]>
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 9912d9f |
github-actions
bot
added
the
Backported to WP Core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up #72572
What?
This pull request checks on the server side whether the current screen is Network Admin, and disables the site editor navigation commands accordingly.
Why?
We disabled the site editor navigation commands on the network admin screen by checking whether the pathname starts with
wp-admin/networkor not. However, the pathname for a multisite installation doesn't necessarily always start with "hoge". The site may be located in a subdirectory.How?
Pass the result of
is_network_adminas an argument to theinitializeCommandPalettefunction, and disable commands based on that value.Testing Instructions
Screenshots or screencast