Components: Stop using rems #72669
Merged
Components: Stop using rems #72669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Bug
|
Size Change: -17 B (0%) Total Size: 2.27 MB
ℹ️ View Unchanged
|
mirka
commented
Oct 24, 2025
| --antialiasing-factor: 100; | ||
| &[aria-orientation='horizontal'] { | ||
| --fade-width: 4rem; | ||
| --fade-width: 64px; |
Member
Author
There was a problem hiding this comment.
I didn't find any intention to make this value change in relation to any relevant font sizes, so I've simply converted this to the equivalent pixel value.
No visual changes (if used in Gutenberg, at least).
|
|
||
| .components-modal__header-heading { | ||
| font-size: 1.2rem; | ||
| font-size: $font-size-x-large; |
Member
Author
There was a problem hiding this comment.
We could have made this the exact px equivalent (19.2px), but I've taken this opportunity to use a standard base-styles value (20px). Does this look ok @WordPress/gutenberg-design ?
| Before | After |
|---|---|
 |
 |
| margin: 8px 0 0; | ||
| font-family: $font-family-body; | ||
| font-size: 0.75rem; | ||
| font-size: $font-size-small; |
Member
Author
There was a problem hiding this comment.
No visual changes (if used in Gutenberg, at least).
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
FYI I tagged this as a bug, but given it only affects usage of the |
|
Flaky tests detected in 6336b70. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18783586782
|
Contributor
|
Sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the usage of
remunits in@wordpress/components.Why?
Our component system is not generally scaled based on rems, which means that sporadic usage of rems can cause unintended inconsistencies in other projects where 1rem is not 16px.
Testing Instructions
See Storybook stories for the affected components. Screenshots are provided in the inline comments.