Core Data: Avoid extraneous when creating a new record#72666
Merged
Conversation
Mamaduka
added
[Type] Bug
Mamaduka
commented
Oct 24, 2025
| return; | ||
| } | ||
| const entityIdKey = entityConfig.key || DEFAULT_ENTITY_KEY; | ||
| const entityIdKey = entityConfig.key ?? DEFAULT_ENTITY_KEY; |
Member
Author
There was a problem hiding this comment.
I think it makes sense to update similar assignments to use the nullish coalescing operator. The entity either has a key defined or will be using the fallback.
I don't expect this to be a breaking change.
Member
Author
There was a problem hiding this comment.
@youknowriad, what do you think about this? Should I make similar changes in other places? Mostly for consistency.
Mamaduka
commented
Oct 24, 2025
| { | ||
| label: __( 'Base' ), | ||
| kind: 'root', | ||
| key: false, |
Member
Author
There was a problem hiding this comment.
The root/base is ready only, but adding this here just in case. Should I include an inline comment on why the key is intentionally false?
Mamaduka
commented
Oct 24, 2025
| label: __( 'Site' ), | ||
| name: 'site', | ||
| kind: 'root', | ||
| key: false, |
Member
Author
There was a problem hiding this comment.
Same here, should I add a comment?
|
Size Change: +26 B (0%) Total Size: 2.27 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1352cf5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18781705070
|
youknowriad
reviewed
Oct 24, 2025
| const entityIdKey = entityConfig.key || DEFAULT_ENTITY_KEY; | ||
| const entityIdKey = entityConfig.key ?? DEFAULT_ENTITY_KEY; | ||
| const recordId = record[ entityIdKey ]; | ||
| const isNewRecord = !! entityIdKey && ! recordId; |
Contributor
There was a problem hiding this comment.
Why are we concerned about entityIdKey here?
Member
Author
There was a problem hiding this comment.
For the root/site, it will be intentionally false - #72666 (comment). It's more like a safeguard.
Contributor
There was a problem hiding this comment.
It's a smallish breaking change I guess but I don't really expect impact, WDYT.
Member
Author
There was a problem hiding this comment.
I don't expect this to break any consumer code.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
Contributor
|
I think it's okay, since it affects performance 👍 |
priethor
added
the
Backport to WP 6.9 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 27, 2025
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: priethor <[email protected]> Co-authored-by: adamsilverstein <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 6db6a7b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #71927.
🚧 Work in Progress 🚧
PR prevents extraneous HTTP requests for entity collections when creating a new entity record.
Why?
When creating a new record,
select.getRawEntityRecordis called withoutid, which results in an unwanted collections query.How?
entityConfig.keytofalsefor entities that represent a single object. For example, the Site settings.saveEntityRecordis updating an existing record or creating a new one, and callgetRawEntityRecordconditionally.Testing Instructions
GETrequestTesting Instructions for Keyboard
Same.
Screenshots or screencast