Latest Comments: Add option to display full comments #72665

sidharthpandita1 · 2025-10-24T13:04:23Z

What?

Replaces the "Display excerpt" toggle with a "Display content" dropdown in the Latest Comments block, providing three options: No content, Excerpt, and Full content.

Why?

The Latest Comments block currently only offers a binary choice (show excerpt or hide it). This limits flexibility for users who want to display the full comment text or hide comment content entirely while still showing author information and metadata. This enhancement provides more granular control over comment display.

How?

Updated block.json to replace the displayExcerpt boolean attribute with a new displayContent string attribute (enum: "none", "excerpt", "full")
Modified edit.js to replace the ToggleControl with a SelectControl dropdown offering three options
Added deprecated.js with migration logic to automatically convert blocks using the old displayExcerpt boolean to the new displayContent string format
Updated index.php rendering logic to:
- Handle backward compatibility by checking for the legacy displayExcerpt attribute first
- Call get_comment_text() when "Full content" is selected
- Call get_comment_excerpt() when "Excerpt" is selected
- Display no content when "None" is selected
Updated CSS class logic to apply has-excerpts class when content is displayed
Added test fixtures (core__latest-comments__deprecated-v1.*) to verify migration works correctly

Testing Instructions

Open a post or page in the block editor
Insert a Latest Comments block
Open the block settings panel on the right sidebar
Locate the "Display content" dropdown (previously "Display excerpt" toggle)
Test each option:
- Select "No content" - verify only comment author, post title, and date (if enabled) are shown
- Select "Excerpt" - verify comment excerpts are displayed (default behavior)
- Select "Full content" - verify full comment text is displayed
Save and view on the frontend to ensure all three options render correctly
Test with comments of varying lengths to ensure full content doesn't break the layout

Backward Compatibility Testing

Test deprecated attribute migration:
- Switch to Code Editor view
- Manually insert an old-format block: 
- Switch back to Visual Editor
- Verify the dropdown shows "No content" selected
- View on frontend - should display no content (only author/date/post title)
- Make any edit to the block (e.g., toggle display avatar)
- Switch back to Code Editor
- Verify the block now uses "displayContent":"none" instead of "displayExcerpt":false
Repeat step 8 with {"displayExcerpt":true} and verify it migrates to "displayContent":"excerpt"

Testing Instructions for Keyboard

Open a post or page in the block editor
Insert a Latest Comments block using the inserter (press / then type "latest comments")
Press Tab to navigate to the block toolbar, then continue tabbing to reach the settings sidebar
Use Tab to navigate to the "Display content" dropdown
Press Space or Enter to open the dropdown
Use Arrow Up/Down keys to navigate through the three options
Press Enter to select an option
Verify the block preview updates accordingly
Use Tab to navigate to other settings and ensure keyboard navigation works smoothly throughout

Screenshots or screencast

Screen.Recording.2025-10-21.at.1.08.29.AM.mov

Additional Notes

The default value is "Excerpt" to maintain existing behavior
The CSS class has-excerpts is applied when content is displayed (excerpt or full)
Full comment content uses get_comment_text() as suggested in the original issue
All comment content is wrapped in wpautop() for proper paragraph formatting
Backward compatibility: Blocks with the old displayExcerpt attribute are automatically migrated via deprecation logic when edited, and render correctly on the frontend via PHP fallback logic
Migration is triggered by isEligible() check that only runs when the legacy displayExcerpt attribute exists
Test fixtures ensure the migration from displayExcerpt: false → displayContent: "none" and displayExcerpt: true → displayContent: "excerpt" works correctly

github-actions · 2025-10-24T13:04:38Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sidharthpandita1 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: Copons <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

… validation Adds new test fixtures for the core/latest-comments block to verify the deprecated v1 migration path. Includes: - core__latest-comments__deprecated-v1.html - core__latest-comments__deprecated-v1.json - core__latest-comments__deprecated-v1.serialized.html These fixtures ensure correct migration from legacy 'displayExcerpt' to the new 'displayContent' attribute.

sidharthpandita1 · 2025-10-24T14:57:03Z

Adds new test fixtures for the core/latest-comments block to verify the deprecated v1 migration path.
Includes:

core__latest-comments__deprecated-v1.html
core__latest-comments__deprecated-v1.json
core__latest-comments__deprecated-v1.serialized.html @t-hamano

t-hamano · 2025-10-24T15:04:35Z

@sidharthpandita1 This PR contains a lot of changes. See the file diff: https://github.com/WordPress/gutenberg/pull/72665/files

sidharthpandita1 · 2025-10-24T15:08:32Z

@sidharthpandita1 This PR contains a lot of changes. See the file diff: https://github.com/WordPress/gutenberg/pull/72665/files

I didn’t make significant modifications to these files — the large diff is likely due to some whitespace or indentation differences introduced during copy–paste.

t-hamano · 2025-10-24T15:15:03Z

I didn’t make significant modifications to these files — the large diff is likely due to some whitespace or indentation differences introduced during copy–paste.

Regardless of the cause, as the CI failures indicate, these changes are unacceptable. Could you revert the unnecessary changes?

sidharthpandita1 · 2025-10-24T15:18:00Z

I didn’t make significant modifications to these files — the large diff is likely due to some whitespace or indentation differences introduced during copy–paste.

Regardless of the cause, as the CI failures indicate, these changes are unacceptable. Could you revert the unnecessary changes?

Absolutely !!

sidharthpandita1 · 2025-10-24T20:01:31Z

@t-hamano removed the extra spacing/indentation of block.json, should i continue the same for the rest?

t-hamano · 2025-10-25T01:33:20Z

@sidharthpandita1 Yes. It would also be a good idea to correctly update the PR title and description.

sidharthpandita1 · 2025-10-25T12:49:55Z

@t-hamano changes made accordingly !

t-hamano · 2025-10-25T14:14:11Z

@sidharthpandita1 There are still a lot of unnecessary changes. Most of them are because the indentation is done with spaces instead of tabs. Can you run the following commands?

Format JS files: npm run format packages/block-library/src/latest-comments/block.json packages/block-library/src/latest-comments/deprecated.js
Format PHP file: npm run format:php
Generate the fixture file correctly: npm run fixtures:regenerate

sidharthpandita1 · 2025-10-25T14:25:04Z

commands ran successfully @t-hamano

packages/block-library/src/latest-comments/index.php

Co-authored-by: Aki Hamano <[email protected]>

packages/block-library/src/latest-comments/deprecated.js

Co-authored-by: Aki Hamano <[email protected]>

packages/block-library/src/latest-comments/deprecated.js

Co-authored-by: Aki Hamano <[email protected]>

t-hamano

Thanks for the update! I think we're almost finished 🙏 Finally, could you run npm run fixtures:regenerate one more time?

packages/block-library/src/latest-comments/edit.js

packages/block-library/src/latest-comments/index.php

Co-authored-by: Aki Hamano <[email protected]>

sidharthpandita1 · 2025-10-25T15:10:33Z

Thanks for the update! I think we're almost finished 🙏 Finally, could you run npm run fixtures:regenerate one more time?

command ran successfully !

t-hamano

LGTM! Finally, could you run npm run docs:build? This should ensure that all CI jobs succeed.

sidharthpandita1 · 2025-10-27T04:37:12Z

npm run docs:build

Done !

Changes made

f338eb6

sidharthpandita1 requested review from ajitbohra and fabiankaegy as code owners October 24, 2025 13:04

sidharthpandita1 mentioned this pull request Oct 24, 2025

Add option to display full comments #72504

Closed

Extra spacing/indentation in block.json

93e7ca9

sidharthpandita1 changed the title ~~Changes made~~ Add option to display full comments/v-2 Oct 25, 2025

removed unnecessary space/indentation

6af4ddf

t-hamano added [Type] Enhancement A suggestion for improvement. [Block] Latest Comments Affects the Latest Comments Block labels Oct 25, 2025

sidharthpandita1 added 2 commits October 25, 2025 19:52

Fix code formatting

893cc21

Fix code formatting

60824c4

t-hamano reviewed Oct 25, 2025

View reviewed changes

packages/block-library/src/latest-comments/index.php Outdated Show resolved Hide resolved

Update packages/block-library/src/latest-comments/index.php

b2385a3

Co-authored-by: Aki Hamano <[email protected]>

t-hamano reviewed Oct 25, 2025

View reviewed changes

packages/block-library/src/latest-comments/deprecated.js Outdated Show resolved Hide resolved

Update packages/block-library/src/latest-comments/deprecated.js

d575a16

Co-authored-by: Aki Hamano <[email protected]>

t-hamano reviewed Oct 25, 2025

View reviewed changes

packages/block-library/src/latest-comments/deprecated.js Outdated Show resolved Hide resolved

Update packages/block-library/src/latest-comments/deprecated.js

48ea51f

Co-authored-by: Aki Hamano <[email protected]>

t-hamano reviewed Oct 25, 2025

View reviewed changes

packages/block-library/src/latest-comments/edit.js Outdated Show resolved Hide resolved

packages/block-library/src/latest-comments/edit.js Outdated Show resolved Hide resolved

packages/block-library/src/latest-comments/index.php Outdated Show resolved Hide resolved

sidharthpandita1 and others added 4 commits October 25, 2025 20:36

Update packages/block-library/src/latest-comments/edit.js

30aa99a

Co-authored-by: Aki Hamano <[email protected]>

Update packages/block-library/src/latest-comments/index.php

258d69a

Co-authored-by: Aki Hamano <[email protected]>

Update packages/block-library/src/latest-comments/edit.js

9ea1ec0

Co-authored-by: Aki Hamano <[email protected]>

fixtures:regenerate

068f3dc

t-hamano changed the title ~~Add option to display full comments/v-2~~ Latest Comments: Add option to display full comments Oct 27, 2025

t-hamano approved these changes Oct 27, 2025

View reviewed changes

Changes made

1ac401d

sidharthpandita1 requested a review from juanmaguitar as a code owner October 27, 2025 04:36

t-hamano merged commit 703897a into WordPress:trunk Oct 27, 2025
34 checks passed

github-actions bot added this to the Gutenberg 22.0 milestone Oct 27, 2025

Latest Comments: Add option to display full comments #72665

Latest Comments: Add option to display full comments #72665

Uh oh!

Conversation

sidharthpandita1 commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Why?

How?

Testing Instructions

Backward Compatibility Testing

Testing Instructions for Keyboard

Screenshots or screencast

Additional Notes

Uh oh!

github-actions bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sidharthpandita1 commented Oct 24, 2025

Uh oh!

t-hamano commented Oct 24, 2025

Uh oh!

sidharthpandita1 commented Oct 24, 2025

Uh oh!

t-hamano commented Oct 24, 2025

Uh oh!

sidharthpandita1 commented Oct 24, 2025

Uh oh!

sidharthpandita1 commented Oct 24, 2025

Uh oh!

t-hamano commented Oct 25, 2025

Uh oh!

sidharthpandita1 commented Oct 25, 2025

Uh oh!

t-hamano commented Oct 25, 2025

Uh oh!

sidharthpandita1 commented Oct 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

t-hamano left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sidharthpandita1 commented Oct 25, 2025

Uh oh!

t-hamano left a comment

Choose a reason for hiding this comment

Uh oh!

sidharthpandita1 commented Oct 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sidharthpandita1 commented Oct 24, 2025 •

edited

Loading

github-actions bot commented Oct 24, 2025 •

edited

Loading