Template activation: revert to old endpoint for post template picker#72661
Merged
Template activation: revert to old endpoint for post template picker#72661
Conversation
|
Size Change: -130 B (-0.01%) Total Size: 2.27 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 30b8aa0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18778091525
|
ellatrix
added
the
[Type] Iteration
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
added
the
Backport to WP 6.9 Beta/RC
github-actions
bot
added
Backported to WP Core
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 24, 2025
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: e203469 |
cbravobernal
added
the
[Type] Code Quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #72586.
Why?
The template property on post objects only receives template slugs, not IDs. This means you cannot just pick any template from the database: you can only pick the active template for a slug, or custom templates, which is basically what the "old" endpoint queries.
How?
For now let's keep the querying the "old" endpoint in place until we refactor this to use IDs. This also allows us to do some backwards compatibility testing and have less surface area of the new feature exposed.
Testing Instructions
Pick templates through the post or page editor (through the modal). There's some e2e tests for this.
Testing Instructions for Keyboard
Screenshots or screencast