Templates: Adds 'type' property to activeField as boolean in page templates
#72648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
the
[Feature] Templates API
6 tasks
|
Size Change: +8 B (0%) Total Size: 2.27 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 5bafbaf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18770826713
|
t-hamano
approved these changes
Oct 24, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Since the activeField returns a boolean value via the getValue property, defining type: 'boolean' seems like the correct approach.
t-hamano
added
the
Backport to WP 6.9 Beta/RC
Member
Author
|
Thanks for the quick reviews! |
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 0e660eb |
github-actions
bot
added
the
Backported to WP Core
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 24, 2025
…) (#72648) Co-authored-by: ramonjd <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: levinbaria <[email protected]> Co-authored-by: jennydupuy <[email protected]>
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 24, 2025
…Press#72278) (WordPress#72648) Co-authored-by: ramonjd <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: levinbaria <[email protected]> Co-authored-by: jennydupuy <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72278 (I think! 🤞🏻 )
What?
Adds 'type' property to
activeFieldas boolean in page templatesWhy?
The
typepassed to getFieldTypeDefinition was undefined.Testing Instructions
Head to Appearance > Templates > Active templates > View Options > Sort by > Status
The templates should be sorted by status