Template activation: fix isActive and isCustom values #72641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +2 B (0%) Total Size: 2.27 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f41aef7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18753663506
|
Contributor
|
While the code changes make sense based on: |
Member
Author
|
I added specific testing instructions. It does not fix the linked issue it’s just a reference |
ntsekouras
approved these changes
Oct 24, 2025
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
As I'd mentioned before the changes in logic make sense, and I tested that This template should show active because it's not a custom template, it's a default template. and works. Thanks!
ellatrix
added
the
Backport to WP 6.9 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 24, 2025
Co-authored-by: ellatrix <[email protected]> Co-authored-by: ntsekouras <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: d0a3f84 |
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 24, 2025
Co-authored-by: ellatrix <[email protected]> Co-authored-by: ntsekouras <[email protected]>
mcsf
reviewed
Oct 24, 2025
| return _records.map( ( record ) => ( { | ||
| ...record, | ||
| _isActive: activeTemplates.find( | ||
| _isActive: !! activeTemplates.find( |
Contributor
There was a problem hiding this comment.
Nit: semantically a perfect candidate for Array#some
mcsf
reviewed
Oct 24, 2025
| ), | ||
| _isCustom: | ||
| record.is_custom || | ||
| record.is_custom ?? |
bph
added
the
[Feature] Templates API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Two typos: isActive should return a boolean values, and isCustom should not ignore a
falsevalue when set.See also #72475.
Why?
How?
Testing Instructions
This template should show active because it's not a custom template, it's a default template.
Testing Instructions for Keyboard
Screenshots or screencast