Block Bindings: Add source label to the modal title UI. #72632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
Contributor
Author
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +10 B (0%) Total Size: 2.19 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in da5e13c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18749000415
|
t-hamano
approved these changes
Oct 23, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
I used the following JS code and block HTML, and confirmed that it works correctly.
wp.blocks.registerBlockBindingsSource( {
name: 'plugin/my-custom-source',
label: 'My Custom Source',
editorUI() {
return {
mode: 'modal',
data: [
{
label: 'Hello World Field',
type: 'string',
args: {
key: 'hello_world'
}
}
],
renderModalContent( { attribute, closeModal } ) {
return wp.element.createElement(
'div',
{},
wp.element.createElement(
'p',
{},
'Hello World'
),
);
},
};
},
} );<!-- wp:paragraph {
"metadata":{
"bindings":{
"content":{
"source":"plugin/my-custom-source"
}
}
}
} -->
<p>Paragraph</p>
<!-- /wp:paragraph -->
Since the title prop seems essential for accessibility, I believe this PR could be considered a bug fix and can be backported to the 6.9 release.
t-hamano
added
the
Backport to WP 6.9 Beta/RC
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9 Editor Tasks
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 24, 2025
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: e985e93 |
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The new Modal version of the Block Bindings UI misses a header, which seems to make the UI somewhat empty. As it contains a header with just the closing button.
This PR adds the source label as the Modal header, so the user knows what source is the modal UI referring to.
Before:
After:
