Build: Add a step to auto-register scripts in the build tool#72628
Merged
youknowriad merged 1 commit intotrunkfrom Oct 24, 2025
Merged
Build: Add a step to auto-register scripts in the build tool#72628youknowriad merged 1 commit intotrunkfrom
youknowriad merged 1 commit intotrunkfrom
Conversation
youknowriad
added
the
[Type] Build Tooling
youknowriad
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 2.19 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 338bcd5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18755793265
|
youknowriad
force-pushed
the
add/auto-register-scripts
branch
from
be74555 to
338bcd5
Compare
youknowriad
added
the
No Core Sync Required
Mamaduka
reviewed
Oct 24, 2025
| * @param bool $in_footer Optional. Whether to enqueue the script before </body> instead of in the <head>. | ||
| * Default 'false'. | ||
| */ | ||
| function gutenberg_override_script( $scripts, $handle, $src, $deps = array(), $ver = false, $in_footer = false ) { |
Member
There was a problem hiding this comment.
This function is still used by gutenberg_register_vendor_scripts and now plugin throws a PHP fatal error without build step.
I think that should be avoided.
Contributor
Author
There was a problem hiding this comment.
The function is generated now though, I didn't remove it.
Contributor
Author
There was a problem hiding this comment.
throws a PHP fatal error without build step.
I guess we should avoid loading "client-assets.php" if the plugin is not built. Probably it's better to avoid loading any php.
Member
There was a problem hiding this comment.
I don't think a build should be required for a plugin to run any PHP. It could create more confusion. Someone clones the repo and activates a plugin, but nothing happens.
What was the main reason for moving gutenberg_override_script to be generated during the build? The gutenberg_override_style is still defined in client-assets.php?
P.S. It took a while to realize why gutenberg_override_script was missing after pulling the trunk 😅
Contributor
Author
There was a problem hiding this comment.
I don't think a build should be required for a plugin to run any PHP. It could create more confusion. Someone clones the repo and activates a plugin, but nothing happens.
This was already the case, if you don't build the plugin you get a message on the admin saying your plugin should be built. I think it should just continue to work the same.
Member
There was a problem hiding this comment.
Maybe we could check if gutenberg_override_script function exists and do the same message, plus stop loading parts of the plugin that will throw a fatal error.
Contributor
Author
There was a problem hiding this comment.
I'm still not seeing any issue though. If the build folder doesn't exist, there's no breakage and you just get the noticed. Maybe you just got in a weird state where you had a build folder but you didn't have the generated php yet. Which in theory, will never happen (unless you're switching form an old branch to a new branch).
Member
There was a problem hiding this comment.
unless you're switching form an old branch to a new branch
Some days, I've to do that a lot 😅
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 24, 2025
…g adhoc code (WordPress#72628) Co-authored-by: youknowriad <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #72032
What
This continues the work on the build tool. This PR auto-registers scripts (like we did modules before) based on the packages built in the current plugin.
Why?
How?
build/scripts/index.php- module registry data arraybuild/scripts.php- registration logic with hooksTesting Instructions
E2E tests should pass (scripts are used everywhere)