Block Bindings: Add bindableAttributes in preview context
#72625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
Contributor
Author
|
If this lands, should be backported to 6.9? 🤔 Personally I think so.. --cc @ellatrix @cbravobernal |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
changed the title
bindableAttributes in preview context
Member
|
We should check that this doesn't affect optimizations from #60543. |
|
Size Change: +3 B (0%) Total Size: 2.19 MB
ℹ️ View Unchanged
|
Contributor
I agree that should be backported. |
ockham
approved these changes
Oct 23, 2025
Contributor
ockham
left a comment
ockham
left a comment
There was a problem hiding this comment.
Thank you, Nik -- I can confirm both the bug in trunk, and that your PR fixes it 👍
If this lands, should be backported to 6.9? 🤔 Personally I think so..
Yeah, definitely!
We should check that this doesn't affect optimizations from #60543.
@Mamaduka Do we have any choice though? The UI is quite broken without this fix 😅
ockham
added
Backport to WP 6.9 Beta/RC
Member
|
If we need it it's fine |
Member
|
I don’t think we have. Let’s merge and monitor CodeVitals. |
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 23, 2025
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: ockham <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: ellatrix <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: b96f57d |
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 24, 2025
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: ockham <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: ellatrix <[email protected]>
cbravobernal
removed
the
Backport to Gutenberg RC
Contributor
|
The code updated is already on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up of: #72351
This PR adds the
bindableAttributesinpreviewContextas well. This results in bindings being processed properly in preview context such as block examples and block previews.You can see the issue without this change in Query Loop block with
Post dateblock, where we are showing the items in block previews:Screen.Recording.2025-10-23.at.12.44.36.PM.mov
Notes
If I'm not missing something, the performance shouldn't be affected by this change, since the main fix in the original PR was about the select call.
Testing Instructions
Start blank.datedatetoPost Datevariation (this is fixed here)