Notes: Render the sidebar next to the default editor sidebar#72618
Merged
Notes: Render the sidebar next to the default editor sidebar#72618
Conversation
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Oct 23, 2025
Comment on lines
+213
to
+228
| export default function NotesSidebarContainer() { | ||
| const postId = useSelect( ( select ) => { | ||
| const { getCurrentPostId } = select( editorStore ); | ||
| return getCurrentPostId(); | ||
| }, [] ); | ||
|
|
||
| if ( ! postId || typeof postId !== 'number' ) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <PostTypeSupportCheck supportKeys="editor.notes"> | ||
| <NotesSidebar postId={ postId } /> | ||
| </PostTypeSupportCheck> | ||
| ); | ||
| } |
Member
Author
There was a problem hiding this comment.
Collocates all rendering conditions in a single container component.
|
Size Change: -62 B (0%) Total Size: 2.19 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in bcf39f8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18742212296
|
t-hamano
approved these changes
Oct 23, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! It works correctly as before.
Member
Author
|
Thanks for the review, @t-hamano! |
github-actions
bot
added
Backported to WP Core
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 23, 2025
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]>
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: de3110d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
As a preparation for #72616, PR moves the Notes sidebar's rendering position. It's now rendered inside the Editor component, next to the default
Sidebar.I've also renamed some of the internal components. I'm not changing the filenames to avoid conflicts when backporting the changes.
Testing Instructions
PR makes no functional changes; all CI checks should be green.
Testing Instructions for Keyboard
Same.