-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Post Date: Fix variations for Query Loop #72617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| }, | ||
| { | ||
| name: 'core/post-date', | ||
| attributes: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example right now is not working and I think that might probably be a general block bindings things, which I'll investigate now.
Nonetheless, this change should be here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might return early for some store subscriptions when isPreviewMode is true. This is usually done for performance.
Here's one related PR I remember - #60544.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fixed by #72625, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct 👍
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +37 B (0%) Total Size: 2.19 MB
ℹ️ View Unchanged
|
|
The fix works on the frontend, but the editor experience has an odd bug. The actual publish date isn't displayed unit I select the block in the Query Loop. ScreencastCleanShot.2025-10-23.at.12.43.59.mp4 |
|
Flaky tests detected in 376be21. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18751200438
|
I know. This is trunk though too, right? I think it's the same problem with the example and I'm investigating now. |
I'm just seeing the current date on the trunk. Yes, seems like the same issue. Post template users block previews internally, IIRC. |
|
I opened a PR to fix the previews here:#72625. |
ockham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Thank you for fixing, and apologies for the oversight when changing the Date block's default behavior.
(Testers, note that you need #72625 to avoid a weird glitch in the editor.)
|
Wow.. I accidentally closed the PR when I merged another one that had in its description (testing instructions) this: I reopened and will merge. |
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ockham <[email protected]>
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: a8b1c8c |
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ockham <[email protected]>
What?
Follow up of: #70585
The above PR essentially updated the default value of
Post Dateblock from published date to a custom date. This PR updates the post date instances that should be the post's published date.Testing Instructions
Start blankdate