Skip to content

Conversation

@roseg43
Copy link
Contributor

@roseg43 roseg43 commented Oct 22, 2025

What?

Closes #72530

This PR adjusts the bottom padding on the Notes sidebar panel so that there's enough room for the box shadow to be fully displayed when the active note is the last note in the list of notes.

Why?

Please refer to #72530

If you select and/or focus a comment in the canvas, it has a white background and a drop shadow. This shadow is slighty cropped at the bottom

Testing Instructions

  1. Open a post or page
  2. Add a note to a block
  3. In the Comments sidebar, select the last note to make it active.
  4. Confirm that the drop shadow beneath the note isn't cut off visually.

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: roseg43 <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: jasmussen <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting labels Oct 23, 2025
@Mamaduka Mamaduka self-requested a review October 23, 2025 05:21
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @roseg43! This fixes the issue in my tests.

cc @jasmussen

@jasmussen
Copy link
Contributor

Unable to test right now, but thank you for working on this.

@Mamaduka Mamaduka merged commit c99daa5 into WordPress:trunk Oct 23, 2025
42 checks passed
@github-actions github-actions bot added this to the Gutenberg 22.0 milestone Oct 23, 2025
@t-hamano
Copy link
Contributor

How about backporting this PR to the 6.9 release?

@Mamaduka Mamaduka added the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Oct 23, 2025
@Mamaduka
Copy link
Member

Mamaduka commented Oct 23, 2025

Sorry, forgot the label :/ I can do a manual backport as needed.

@t-hamano
Copy link
Contributor

@Mamaduka For some reason, auto cherry-picking didn't seem to work 🤔

Input required and not supplied: token

@Mamaduka
Copy link
Member

I can do it manually.

Mamaduka added a commit that referenced this pull request Oct 23, 2025
…t is the last one. (#72606)

Co-authored-by: roseg43 <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Mamaduka added a commit that referenced this pull request Oct 23, 2025
…t is the last one. (#72606)

Co-authored-by: roseg43 <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: jasmussen <[email protected]>
@Mamaduka
Copy link
Member

Done ✅

@Mamaduka Mamaduka removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block notes: Drop shadow is cropped

4 participants