-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Block Notes: Fix issue where box shadow is cut off when active note is the last one. #72606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Notes: Fix issue where box shadow is cut off when active note is the last one. #72606
Conversation
…t is the last one.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @roseg43! This fixes the issue in my tests.
cc @jasmussen
|
Unable to test right now, but thank you for working on this. |
|
How about backporting this PR to the 6.9 release? |
|
Sorry, forgot the label :/ I can do a manual backport as needed. |
|
@Mamaduka For some reason, auto cherry-picking didn't seem to work 🤔 Input required and not supplied: token |
|
I can do it manually. |
…t is the last one. (#72606) Co-authored-by: roseg43 <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: jasmussen <[email protected]>
…t is the last one. (#72606) Co-authored-by: roseg43 <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: jasmussen <[email protected]>
|
Done ✅ |
What?
Closes #72530
This PR adjusts the bottom padding on the Notes sidebar panel so that there's enough room for the box shadow to be fully displayed when the active note is the last note in the list of notes.
Why?
Please refer to #72530
Testing Instructions