Global Styles: Add UI package #72599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
andrewserong,
ramonjd,
t-hamano and
tellthemachines
youknowriad
added
the
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1.42 kB (+0.06%) Total Size: 2.19 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
add/global-styles-ui
branch
from
f6c988d to
ba83d81
Compare
Member
|
I only got time to test the following today (in the site editor and in the style section of site admin) ✅ Test main navigation 👍🏻 |
Member
|
Hmm that failing E2E test passing for my locally. I'll re-run and see |
|
Flaky tests detected in 9a298a1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18743612455
|
Contributor
Author
|
Merging, this to continue the work, but I'll address whatever issues are raised, please ping me. |
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 24, 2025
Co-authored-by: youknowriad <[email protected]> Co-authored-by: ramonjd <[email protected]>
This was referenced Nov 10, 2025
ramonjd
reviewed
Nov 25, 2025
| [ name ] | ||
| ); | ||
| const [ variations ] = useGlobalStyle( 'variations', name ); | ||
| const [ variations ] = useSetting( 'variations', name ); |
Member
There was a problem hiding this comment.
Looks like this one fell through our net
useGlobalStyle => useStyle not useSetting
Fix here:
This was referenced Dec 3, 2025
This was referenced Dec 4, 2025
t-hamano
added
the
Global Styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of this issue #72317 with the final goal of bringing global styles to the post editor.
What?
This PR extracts the Global Styles UI components from
@wordpress/edit-siteinto a new standalone package@wordpress/global-styles-ui.Why?
The Global Styles UI components were deeply embedded within the edit-site package, making them difficult to reuse in other contexts (like the post editor). By creating a dedicated package:
How?
Package Structure
@wordpress/global-styles-uipackage with its ownpackage.jsonand dependencies.tsx,.ts)Integration Layer in edit-site
edit-site/src/components/global-styles/(the big part here is sync between the global styles open panel and the stylebook)hooks.jsto provide auseGlobalStyles()hook that simplifies access to the default global styles. I think this could be useful as package (or within the same package) but I'm hesitant to move to the package because folks might take shortcuts when writing the UI components. (We shouldn't be reading from core-data and updating core-data from the UI component)Testing Instructions
It's a big PR, to be honest, I'd might not sure I'd have accepted a similar PR but I think it's better to than having to do all of these (100 UI components) one by one. The changes are mechanical most of the time and I don't want this migration to take forever.
I didn't test everything extensively yet but I could use some help. we need to test carefully.