Use padding appender hook in Site editor #72598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Bug
|
Size Change: -137 B (-0.01%) Total Size: 2.38 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in db40595. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18983657151
|
youknowriad
reviewed
Oct 31, 2025
| 'edit-site-editor__loading-progress' | ||
| ); | ||
|
|
||
| const [ paddingAppenderRef, paddingStyle ] = usePaddingAppender( |
Contributor
There was a problem hiding this comment.
Instead of duplicating the logic between post and site editor, Should we just move it to the "editor" component (there's already a number of similar hooks there)
Contributor
Author
There was a problem hiding this comment.
Most definitely. I gave that a look initially but missed that it could indeed work simply (I thought it'd require and added a prop on Editor). Now, the hook is incorporated into VisualEditor which is the one I assume you meant.
stokesman
force-pushed
the
update/move-padding-appender-hook
branch
from
8bd47ce to
db40595
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
It's looking good to me code wise. I can't give it a proper test at the moment. I'd love if some one can test a little bit. Otherwise this is great. Thanks :) |
youknowriad
reviewed
Oct 31, 2025
| templateId={ templateId } | ||
| className={ className } | ||
| forceIsDirty={ hasActiveMetaboxes } | ||
| contentRef={ paddingAppenderRef } |
Contributor
There was a problem hiding this comment.
Wondering if contentRef is still needed or if we can remove the prop from the editor components.
youknowriad
reviewed
Nov 4, 2025
| } | ||
|
|
||
| return baseStyles; | ||
| return hasThemeStyles ? settings.styles ?? [] : defaultEditorStyles; |
Contributor
There was a problem hiding this comment.
Theme styles toggle is another thing that we should move to the editor package.
Contributor
Author
There was a problem hiding this comment.
🤔 I supposed that would always remain a Post editor only feature.
Contributor
Author
There was a problem hiding this comment.
I suppose it was just a feeling that it would have already been done if it were desirable. I could see wanting to have the logic for handling it in the editor package and maybe that’s all you're suggesting. Unless there is demand, I wouldn’t think the site editor should expose the toggle in the preferences UI for now.
youknowriad
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #65925
Adds the ability to click after the post content to add the default block when editing in post-only mode.
Why?
For parity with the post-only editing experience in the Post editor.
How?
Moves the hook to the editor package and incorporates it into
VisualEditor.Additionally cleans up a now unused rest parameter in a hook of the edit-post’s Layout component db40595
Testing Instructions
For both post and site editors
Site Editor specific
After verifying the padding is applied, open the navigation so the page is shown in view mode and ensure the padding is not added after the post content.
Note
I think the padding appender is supposed to focus the last default block if one‘s already inserted and that doesn’t seem to be working but seems to be the case before these changes. UPDATE: this was also noted by @Mamaduka and there’s fix in #72821.