Size Change: -71 B (0%)

Total Size: 2.19 MB

_{compressed-size-action}

Flaky tests detected in 3e56a64.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18714165154
📝 Reported issues:

• [Flaky Test] ensures List View global shortcut works properly #51533 in /test/e2e/specs/editor/various/list-view.spec.js

Thanks for following up here. I'm OK with merging, but this PR highlights a preëxisting problem: at least on my computer, regardless of browser, the size calculation results in the three initial keypresses ("abc") not quite fitting:

It's not exactly that they don't fit the screen. They do fit, but only if you scroll slightly. The problem seems related to the height of the caret itself, which is always re-centred in the viewport on each keypress. Thoughts, @jorgefilipecosta?

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jorgefilipecosta <[email protected]>
Co-authored-by: mcsf <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

The other thing is totally unrelated to this PR, but I'd still like us to track and see if we can improve:

I'd love it if we could hide the flash that happens during the binary search for optimal size. In the video above it happens with the empty-block placeholder, but of course this also applies to actual text.

Hi @mcsf thank you a lot for the review and testing 👍

Thanks for following up here. I'm OK with merging, but this PR highlights a preëxisting problem: at least on my computer, regardless of browser, the size calculation results in the three initial keypresses ("abc") not quite fitting:

The first issue, although not ideal, seems to be the expected behavior. The paragraph is directly inside content, and the content area has no height restrictions (it can grow indefinitely, the scroll happens on the container of the content / iframe but the content height itself grows, so in that scenario fit text is only limited by the width, so regarding the height scroll may happen or not depending on the window size as the images below show:

I'd love it if we could hide the flash that happens during the binary search for optimal size. In the video above it happens with the empty-block placeholder, but of course this also applies to actual text.

That flashing is something we can try to improve, maybe with hiding during the binary search or something similar.

I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 8c352e7