-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Use default popover placement for image format popover #72550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -1 B (0%) Total Size: 2.18 MB
ℹ️ View Unchanged
|
t-hamano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
|
Thanks for the review, Aki 🙇 |
What, Why, How?
A fix for a bug where the image format’s popover goes partially offscreen because it should not do that. This just removes the
placementprop so the default is used and that works better.Testing Instructions
Open a post
Paste the following (a full width group so the image is sure to be close to the canvas edge):
Select the image so its popover appears
Verify the popover is not going offscreen
Screenshots or screencast
Looking at this, I now wonder if the popover wouldn’t look better with small
offset. I’ll keep this PR focused though.