Notes: Fix 'View notes' on mobile screens #72546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Oct 21, 2025
Comment on lines
+120
to
+121
| isLargeViewport && | ||
| ( unresolvedSortedThreads.length > 0 || showCommentBoard ) |
Member
Author
There was a problem hiding this comment.
There's no point in enabling the useEnableFloatingSidebar hook logic on smaller screens.
|
Size Change: +21 B (0%) Total Size: 2.18 MB
ℹ️ View Unchanged
|
Mamaduka
added
the
Backport to WP 6.9 Beta/RC
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
|
Flaky tests detected in ac6e08d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18694501690
|
Member
Author
|
Thanks for the review, @t-hamano! |
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9 Editor Tasks
talldan
pushed a commit
that referenced
this pull request
Oct 22, 2025
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: jasmussen <[email protected]>
talldan
removed
the
Backport to WP 6.9 Beta/RC
Contributor
|
I've cherry-picked this manually onto the |
Contributor
|
Thanks for this! |
ellatrix
pushed a commit
that referenced
this pull request
Oct 22, 2025
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: jasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #71834.
Closes #72531.
PR fixes "View notes" and "Add note" block toolbar/option items when editor is rendered in smaller viewports.
Why?
Floating notes are disabled on smaller screens since they're not dismissible and prevent content editing.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2025-10-21.at.22.49.25.mp4