Build: Auto-register script modules #72541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ajitbohra,
nerrad,
ntwb and
spacedmonkey
as code owners
youknowriad
added
the
[Type] Build Tooling
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
Oct 21, 2025
lib/client-assets.php
Outdated
| 'fetchpriority' => 'low', | ||
| ); | ||
|
|
||
| gutenberg_register_interactive_script_module_id( $script_module_id ); |
Contributor
Author
There was a problem hiding this comment.
I think this is the only thing that I'm unsure about, what is this for, which modules should be marked as "interactive", all of them? Can you help @DAreRodz
Member
There was a problem hiding this comment.
Please, merge/rebase trunk in this branch, as that code has been changed here.
Basically, we're using the wp_script_attributes filter to add a new directive (data-wp-router-options='{"loadOnClientNavigation":true}') to all the script modules that belong to interactive blocks. This helps detect them when the Interactivity API router navigates and needs to load the ones that didn't exist on the previous page.
More info on the WP Core patch:
Member
There was a problem hiding this comment.
which modules should be marked as "interactive", all of them?
Here we are marking all the script modules belonging to the interactive Core blocks, since they are all compatible with client-side navigation.
Contributor
Author
There was a problem hiding this comment.
The code in trunk was merging all the modules without exceptions as compatible. I can update the code to explicitly mark the block ones. (after rebase)
Member
There was a problem hiding this comment.
We did it like this in the PR:
if ( str_starts_with( $script_module_id, '@wordpress/block-library' ) ...
wp_interactivity()->add_client_navigation_support_to_script_module( $script_module_id );
Contributor
Author
There was a problem hiding this comment.
I kept it as is for now but outside the scripts registration. So it should work the same but I don't really know what to test :)
Member
There was a problem hiding this comment.
I don't think we have tests for the Core blocks, just for the third-party blocks. I'll check it out, don't worry.
youknowriad
force-pushed
the
add/auto-register-modules
branch
from
04c5927 to
0ff77e8
Compare
|
Size Change: 0 B Total Size: 2.19 MB ℹ️ View Unchanged
|
youknowriad
force-pushed
the
add/auto-register-modules
branch
from
0ff77e8 to
6414238
Compare
youknowriad
added
the
No Core Sync Required
|
Flaky tests detected in e8aab75. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18725435060
|
Contributor
Author
|
I'd appreciate a final review here. Things work well for me and I would love to expand this to scripts, styles in a follow-up. |
Contributor
Author
|
Oh forgot the props, sorry Luis 😬 |
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 24, 2025
Contributor
Author
|
Looks like this PR improved the server loading metrics, My guess is it's because of the removal of the directory travel to find modules and the move to explicit discovery (build based) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #72032
What
This continues the work on the build tool. This is the first PR where we're introducing automatic php code generation. This PR auto-registers script modules based on the packages built in the current plugin.
Why?
wpPlugin.prefixconfig (support other plugins later)How?
build/modules/index.php- module registry data arraybuild/index.php- registration logic with hookslib/client-assets.phpTesting Instructions
You can check that interactive blocks continue to work on the frontend.