Skip to content

Improve output buffer for sending server-timing header #72536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowriad merged 2 commits into from
Oct 21, 2025
Merged

Improve output buffer for sending server-timing header #72536

youknowriad merged 2 commits into from
Oct 21, 2025

Conversation

@westonruter
Copy link
Member

@westonruter westonruter commented Oct 21, 2025 •
edited
Loading

See Slack thread.

Fixes E2E issues like this:

image

To reproduce the original issue, active the Twenty Twenty-One theme,

Create and activate a gutenberg-e2e-server-timing.php file in your plugins directory which contains:

<?php
/**
 * Plugin Name: Gutenberg E2E Server Timing
 */

require_once __DIR__ . '/gutenberg/packages/e2e-tests/mu-plugins/server-timing.php';

Then publish a post which contains the following post_content:

<!-- wp:paragraph {"style":{"elements":{"link":{"color":{"text":"var:preset|color|white"}}}}} -->
<p class="has-link-color">Check out this link: <a href="/">HOME</a></p>
<!-- /wp:paragraph -->

When working correctly, the link in the paragraph should be white. When failing, the link has no overridden color.

Diff showing prettiered HTML with expected and actual output when failure happens: https://gist.github.com/westonruter/7da9c101d9f4429c2c40bf2907e8cd9f

@github-actions
Copy link

github-actions bot commented Oct 21, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: youknowriad <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter westonruter added [Type] Bug An existing feature does not function as intended [Tool] E2E Test Utils /packages/e2e-test-utils [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. and removed [Type] Bug An existing feature does not function as intended [Tool] E2E Test Utils /packages/e2e-test-utils labels Oct 21, 2025
youknowriad
youknowriad approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping it would fix all the e2e test failures but it didn't.

It did fix a couple (color support and content locking) If I'm looking properly.

@youknowriad
Copy link
Contributor

youknowriad commented Oct 21, 2025

I pushed a small command palette fix that should hopefully fix the remaining e2e test failures (related to command palette)

@youknowriad youknowriad added No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Oct 21, 2025
@youknowriad youknowriad enabled auto-merge (squash) October 21, 2025 15:33
@github-actions
Copy link

github-actions bot commented Oct 21, 2025

Flaky tests detected in a530420.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18688592555
📝 Reported issues:

@youknowriad youknowriad merged commit 6d8fd43 into trunk Oct 21, 2025
42 of 43 checks passed
@youknowriad youknowriad deleted the fix/gutenberg-e2e-server-timing-mu-plugin branch October 21, 2025 15:46
@github-actions github-actions bot added this to the Gutenberg 22.0 milestone Oct 21, 2025
@westonruter westonruter mentioned this pull request Oct 21, 2025
Merged
talldan pushed a commit that referenced this pull request Oct 22, 2025
@westonruter @youknowriad @talldan
Improve output buffer for sending server-timing header (#72536)
93e30b7 
Co-authored-by: westonruter <[email protected]>
Co-authored-by: youknowriad <[email protected]>
@talldan talldan removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Oct 22, 2025
@talldan
Copy link
Contributor

talldan commented Oct 22, 2025

I've cherry-picked this manually onto the wp/6.9 branch.

ellatrix pushed a commit that referenced this pull request Oct 22, 2025
@westonruter @youknowriad @ellatrix
Improve output buffer for sending server-timing header (#72536)
bb45221 
Co-authored-by: westonruter <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

No one assigned

Labels

No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Milestone

Gutenberg 22.0

Development

Successfully merging this pull request may close these issues.

4 participants

@westonruter @youknowriad @talldan