Update: Disable font size when fit text is enabled and the opposite. #72533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jorgefilipecosta
added
[Type] Bug
|
Size Change: +67 B (0%) Total Size: 2.18 MB
ℹ️ View Unchanged
|
t-hamano
added
the
Backport to WP 6.9 Beta/RC
jorgefilipecosta
force-pushed
the
update/remove-font-size-on-fit-text
branch
from
f81a2b5 to
5600f54
Compare
Contributor
|
It seems that this PR could not be automatically cherry-picked into the Normally, the bot would add a comment indicating that a conflict has occurred, but something is wrong with the CI itself. In any case, we'll need to create a manual backport PR against the |
t-hamano
added a commit
that referenced
this pull request
Oct 22, 2025
…72533) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: t-hamano <[email protected]>
This was referenced Oct 22, 2025
Merged
jeryj
reviewed
Oct 22, 2025
Comment on lines
127
to
130
| const value = useMemo( | ||
| () => attributesToStyle( { style, fontFamily, fontSize } ), | ||
| [ style, fontSize, fontFamily ] | ||
| ); |
Contributor
There was a problem hiding this comment.
Should fitText get memoized too?
Contributor
|
No strong opinions, but personally I find it better when we do not update other attributes like this. I think that preserving the previous attribute is valuable when a user had a custom font size and just tries out fit text to see how it feels, and if they don't like it and disable it, they don't have to set again the previous font size. |
t-hamano
added a commit
that referenced
this pull request
Oct 23, 2025
…2e tests (#72584) * Add end to end tests for Fit Text (#72406) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: mcsf <[email protected]> * Update: Disable font size when fit text is enabled and the opposite. (#72533) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: t-hamano <[email protected]> --------- Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: mcsf <[email protected]>
Contributor
|
Note that this PR has been manually backported to the |
t-hamano
removed
the
Backport to WP 6.9 Beta/RC
Contributor
I agree with this, but it probably requires introducing a new That's why I've proposed this approach in this PR as a fix for the 6.9 release. We can try a different approach in a follow-up if needed. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #72492.
This PR applies a suggestion by @t-hamano, it toggles off fit text when a font size is selected, and clears the font size selection when fit text is toggled on.
Testing Instructions
Verify the end to end tests pass.
Add a paragraph select a font size, enable fit text, verify the font size is removed.
Select a font size again verify fit text is removed.