Skip to content

Fix password suffix alignment #72524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mirka merged 3 commits into from
Oct 24, 2025
Merged

Fix password suffix alignment #72524

mirka merged 3 commits into from
Oct 24, 2025

Conversation

@heavyweight
Copy link
Contributor

@heavyweight heavyweight commented Oct 21, 2025

What?

#71545 (comment)

The password field suffix was not properly configured and aligned.

Closes

Why?

  • The suffix was not wrapped with InputControlSuffixWrapper

How?

Testing Instructions

  • Checkout this PR.
  • Run npm run storybook:dev.
  • Visit the dataform validation story ?path=/story/dataviews-dataform--validation.
  • The suffix of the password field should be correctly aligned.

Testing Instructions for Keyboard

Screenshots or screencast

Before After
Screenshot 2025-10-21 at 14 35 59 Screenshot 2025-10-21 at 14 33 31

@github-actions
Copy link

github-actions bot commented Oct 21, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: heavyweight <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: mirka <[email protected]>
Co-authored-by: oandregal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra juanfra added [Type] Enhancement A suggestion for improvement. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Oct 21, 2025
juanfra
juanfra reviewed Oct 21, 2025
View reviewed changes
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left a couple of comments so we can match the reference implementation one-to-one.

@heavyweight heavyweight force-pushed the fix/dataform-password-suffix branch from f44943f to b4528dd Compare October 22, 2025 15:29
juanfra
juanfra approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Let’s loop in @mirka to make sure everything looks good on her end.

@oandregal
Copy link
Member

oandregal commented Oct 23, 2025

@heavyweight there's a CI job failure due to the lack of changelog entry. Every PR to the dataviews package needs to be documented there, so consumers of the npm package can track the changes easily.

mirka
mirka approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the follow up @heavyweight, and thanks @juanfra for the spot-on review 🙏

@heavyweight heavyweight force-pushed the fix/dataform-password-suffix branch from 2619a8a to 49cf2df Compare October 24, 2025 08:10
juanfra
juanfra reviewed Oct 24, 2025
View reviewed changes
@heavyweight heavyweight force-pushed the fix/dataform-password-suffix branch from 49cf2df to d68ecc2 Compare October 24, 2025 08:18
@heavyweight heavyweight force-pushed the fix/dataform-password-suffix branch from d68ecc2 to 4459d54 Compare October 24, 2025 08:20
@mirka mirka merged commit 8ff0758 into WordPress:trunk Oct 24, 2025
33 checks passed
@github-actions github-actions bot added this to the Gutenberg 22.0 milestone Oct 24, 2025
sidharthpandita1 pushed a commit to sidharthpandita1/gutenberg that referenced this pull request Oct 24, 2025
@heavyweight @juanfra
@mirka @oandregal @sidharthpandita1
Fix password suffix alignment (WordPress#72524)
b5487b9 
* Fix password suffix alignment

* Fixup button attrs

* Add changelog entry

Co-authored-by: heavyweight <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: mirka <[email protected]>
Co-authored-by: oandregal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juanfra juanfra juanfra approved these changes

@mirka mirka mirka approved these changes

@oandregal oandregal Awaiting requested review from oandregal oandregal is a code owner

Assignees

No one assigned

Labels

[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 22.0

Development

Successfully merging this pull request may close these issues.

4 participants

@heavyweight @oandregal @juanfra @mirka