Notes: Fix the 'glitch' when selecting a note with a missing block #72516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
juanfra
approved these changes
Oct 21, 2025
Member
juanfra
left a comment
juanfra
left a comment
There was a problem hiding this comment.
Thanks for the PR! It's working well for me, code looks good.
note-glitch.mp4
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
I realized there are a couple more minor issues with Notes in this (missing block) state. I'll consolidate fixes here to make backporting easier. |
Mamaduka
force-pushed
the
fix/notes-missing-block-glitch
branch
from
6b15cca to
3338a90
Compare
Mamaduka
commented
Oct 21, 2025
Member
Author
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Pushed the following changes:
- Updated orphaned thread checks to use
thread.blockClientIdwhen possible. - Added a condition to hide the "Back to block" button.
| // pass `null` as the second parameter to prevent focusing the block. | ||
| selectBlock( thread.blockClientId, null ); | ||
| toggleBlockSpotlight( thread.blockClientId, true ); | ||
| if ( !! thread.blockClientId ) { |
Member
Author
There was a problem hiding this comment.
The blockClientId will be undefined for orphaned threads.
Comment on lines
+538
to
+550
| { !! thread.blockClientId && ( | ||
| <Button | ||
| className="editor-collab-sidebar-panel__skip-to-block" | ||
| variant="secondary" | ||
| size="compact" | ||
| onClick={ ( event ) => { | ||
| event.stopPropagation(); | ||
| relatedBlockElement?.focus(); | ||
| } } | ||
| > | ||
| { __( 'Back to block' ) } | ||
| </Button> | ||
| ) } |
Member
Author
There was a problem hiding this comment.
There's no block to return two, so we can hide this option.
|
Size Change: +14 B (0%) Total Size: 2.17 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3338a90. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18690634914
|
talldan
pushed a commit
that referenced
this pull request
Oct 22, 2025
…72516) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: juanfra <[email protected]>
talldan
removed
the
Backport to WP 6.9 Beta/RC
Contributor
|
I've cherry-picked this manually onto the |
ellatrix
pushed a commit
that referenced
this pull request
Oct 22, 2025
…72516) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: juanfra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #66377.
PR fixes a minor "glitch" when selecting a note with a missing block. This also prevented note selection and prevented users from performing associated actions.
Why?
Selecting a note also selects the associated block, which no longer exists, and the selection is clear. The selection change then resets the selected thread state.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2025-10-21.at.13.37.04.mp4