Real-time collaboration: Ensure Yjs imports are inside experimental flag check #72503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriszarate
added
[Feature] Real-time Collaboration
ellatrix
added
the
Backport to WP 6.9 Beta/RC
|
Size Change: 0 B Total Size: 2.17 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 5305a6b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18662357566
|
youknowriad
reviewed
Oct 20, 2025
| }; | ||
|
|
||
| if ( window.__experimentalEnableSync ) { | ||
| if ( globalThis.IS_GUTENBERG_PLUGIN ) { |
Contributor
There was a problem hiding this comment.
I'm guessing there's a lint rule forcing us to do nested conditions right?
Contributor
Author
There was a problem hiding this comment.
Yes. :)
youknowriad
approved these changes
Oct 20, 2025
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
This PR doesn't need a |
Member
|
@t-hamano, it does. The following warning happens when syncing packages with core and will require this fix.
|
Member
|
Yes it does, see WordPress/wordpress-develop#10355 |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Oct 21, 2025
Updates the packages to match Gutenberg version 21.9.0 RC2. Also updates the sync script to work with the new `package-lock.json` format. Some reusable block tests were adjusted to work with more render arguments. Added `core-data` to the ignore list for `verify:source-maps` because Yjs has been bundled by accident. To be removed in a follow-up. See https://core.trac.wordpress.org/ticket/64120. See WordPress/gutenberg#72503. See: #10355. See: https://core.trac.wordpress.org/ticket/64117. Props ellatrix, dmsnell. Fixes #64117. git-svn-id: https://develop.svn.wordpress.org/trunk@61009 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Oct 21, 2025
Updates the packages to match Gutenberg version 21.9.0 RC2. Also updates the sync script to work with the new `package-lock.json` format. Some reusable block tests were adjusted to work with more render arguments. Added `core-data` to the ignore list for `verify:source-maps` because Yjs has been bundled by accident. To be removed in a follow-up. See https://core.trac.wordpress.org/ticket/64120. See WordPress/gutenberg#72503. See: WordPress/wordpress-develop#10355. See: https://core.trac.wordpress.org/ticket/64117. Props ellatrix, dmsnell. Fixes #64117. Built from https://develop.svn.wordpress.org/trunk@61009 git-svn-id: http://core.svn.wordpress.org/trunk@60345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Oct 21, 2025
Updates the packages to match Gutenberg version 21.9.0 RC2. Also updates the sync script to work with the new `package-lock.json` format. Some reusable block tests were adjusted to work with more render arguments. Added `core-data` to the ignore list for `verify:source-maps` because Yjs has been bundled by accident. To be removed in a follow-up. See https://core.trac.wordpress.org/ticket/64120. See WordPress/gutenberg#72503. See: WordPress/wordpress-develop#10355. See: https://core.trac.wordpress.org/ticket/64117. Props ellatrix, dmsnell. Fixes #64117. Built from https://develop.svn.wordpress.org/trunk@61009 git-svn-id: https://core.svn.wordpress.org/trunk@60345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
chriszarate
deleted the
fix/yjs-import-outside-experimental-flag-check
branch
talldan
pushed a commit
that referenced
this pull request
Oct 22, 2025
talldan
removed
the
Backport to WP 6.9 Beta/RC
Contributor
|
I've cherry-picked this manually onto the |
ellatrix
pushed a commit
that referenced
this pull request
Oct 22, 2025
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Nov 7, 2025
Yjs was bundled by accident in the `core-data` package, so we had to ignore the source map verification in an earlier package sync ([61009]). This can now be restored because the issue was fixed in WordPress/gutenberg#72503. Fixes #64120. git-svn-id: https://develop.svn.wordpress.org/trunk@61184 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Nov 7, 2025
Yjs was bundled by accident in the `core-data` package, so we had to ignore the source map verification in an earlier package sync ([61009]). This can now be restored because the issue was fixed in WordPress/gutenberg#72503. Fixes #64120. Built from https://develop.svn.wordpress.org/trunk@61184 git-svn-id: http://core.svn.wordpress.org/trunk@60520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Nov 7, 2025
Yjs was bundled by accident in the `core-data` package, so we had to ignore the source map verification in an earlier package sync ([61009]). This can now be restored because the issue was fixed in WordPress/gutenberg#72503. Fixes #64120. Built from https://develop.svn.wordpress.org/trunk@61184 git-svn-id: https://core.svn.wordpress.org/trunk@60520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensure Yjs imports are inside an experimental flag check.
Why?
Code inside experimental flag checks is removed, which allows any code it imports or calls to be tree-shaken from WordPress release builds.
How?
syncConfiginside experimental flag check.createSyncManagerinside experimental flag check.Testing Instructions
Since we are testing the effect of this change on WordPress builds, this gets a little tricky.
npm run build.wordpress-develop.npm run sync-gutenberg-packagesWarning: The build/wp-includes/js/dist/core-data.js file must not contain a sourceMappingURL.core-datafiles from step 2 into the WordPress project, e.g.:cd node_modules/@wordpress/core-datarm -rf build*cp -r ../../../../gutenberg/packages/core-data/build* .core-datapackage from being overwritten.npm run sync-gutenberg-packagesTesting Instructions for Keyboard
n/a