Skip to content

Dataviews: Make bulk actions text based. #72501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorgefilipecosta merged 1 commit into from
Oct 21, 2025
Merged

Dataviews: Make bulk actions text based. #72501

jorgefilipecosta merged 1 commit into from
Oct 21, 2025

Conversation

@jorgefilipecosta
Copy link
Member

@jorgefilipecosta jorgefilipecosta commented Oct 20, 2025

Follow up to #72417.
Makes bulk actions actions text buttons instead of icons like we did for the single primary actions.

Screenshots

Screenshot 2025-10-20 at 17 48 10 Screenshot 2025-10-20 at 17 47 57 Screenshot 2025-10-20 at 17 47 26

Testing Instructions

Verify bulk actions for pages, templates, and patterns still work as before.

@github-actions
Copy link

github-actions bot commented Oct 20, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jorgefilipecosta <[email protected]>
Co-authored-by: oandregal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jorgefilipecosta jorgefilipecosta mentioned this pull request Oct 20, 2025
Merged
@mtias mtias added the Needs Design Feedback Needs general design feedback. label Oct 20, 2025
@jorgefilipecosta jorgefilipecosta added [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement. labels Oct 20, 2025
oandregal
oandregal approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@oandregal oandregal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want some design feedback, but this is fine code-wise.

I wonder if we should remove the icon from the actions API — though that can be done later, in a follow-up when we are sure of the text-only direction.

@jorgefilipecosta jorgefilipecosta merged commit 977ac21 into trunk Oct 21, 2025
86 of 91 checks passed
@jorgefilipecosta jorgefilipecosta deleted the update/make-bulk-actions-text-based branch October 21, 2025 07:34
@github-actions github-actions bot added this to the Gutenberg 22.0 milestone Oct 21, 2025
@jorgefilipecosta jorgefilipecosta added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) and removed [Type] Enhancement A suggestion for improvement. labels Oct 21, 2025
priethor pushed a commit that referenced this pull request Oct 21, 2025
@jorgefilipecosta @oandregal @priethor
Dataviews: Make bulk actions buttons text based (#72501)
c5ab62e 
Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: oandregal <[email protected]>
@priethor
Copy link
Contributor

priethor commented Oct 21, 2025

Cherry-picked to the wp/latest branch to include it in WordPress 6.9 Beta1 in c5ab62e

@priethor priethor removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Oct 21, 2025
priethor pushed a commit that referenced this pull request Oct 21, 2025
@jorgefilipecosta @oandregal @priethor
Dataviews: Make bulk actions buttons text based (#72501)
416d158 
Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: oandregal <[email protected]>
@priethor
Copy link
Contributor

priethor commented Oct 21, 2025

I just cherry-picked this PR to the release/21.9 branch to get it included in the next release: 416d158

@priethor priethor removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Oct 21, 2025
@lezama lezama mentioned this pull request Oct 28, 2025
Merged
@oandregal oandregal mentioned this pull request Oct 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oandregal oandregal oandregal approved these changes

@jameskoster jameskoster Awaiting requested review from jameskoster

Assignees

No one assigned

Labels

[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 21.9

Development

Successfully merging this pull request may close these issues.

5 participants

@jorgefilipecosta @priethor @oandregal @mtias