-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Fix Query Loop block rendering for users without permissions to edit the post type #72500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
Size Change: +27 B (0%) Total Size: 2.17 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 09a5dcb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18657831305
|
What?
There is currently a bug that users without permissions to edit a specific product type aren't allowed to see the Query Loop block in the editor if it queries that product type. For example, if an author user edits a post containing the Query Loop block with Pages as the post type, the block only renders an infinite spinner.
Why?
While right now users are not allowed to select post types they don't have permissions to edit in the Query Loop block, other users might modify their posts and add the block. Right now, Gutenberg only renders an infinite scroll which seems broken.
In addition to that, some plugins out there like WooCommerce might use blocks like Post Title for products and make them available to users without permission to edit titles.
How?
This PR:
context: view, so users don't need to have permission to edit that post type to be able to see the Query Loop block preview.context: view, so the correct title is displayed.Testing Instructions
Only Gutenberg:
On WooCommerce: