Perf: Avoid rich-text binding subscription if block does not have bindings #72496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeryj
added
[Type] Performance
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +12 B (0%) Total Size: 2.21 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6258aaa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18719927200
|
youknowriad
reviewed
Oct 20, 2025
Contributor
|
Nice to see more folks looking into performance :) @ellatrix might be a good person to review when it comes to RichText. Although my guess is that this part is over optimized already, I'd love to find wins there. |
Member
|
Nice exploration, @jeryj! One of the bottlenecks that @ellatrix and @jsnajdr discovered when doing optimization is number of store subscriptions, especially to the Redux stores have an O(n) subscription setup. N selected components means N subscriber callbacks and selectors run on every dispatch. |
Member
|
What's the performance gain on average on how many runs? |
Member
|
I can check after beta 1, if I forget, ping me :) |
jeryj
force-pushed
the
perf/rich-text-typing
branch
from
114db5d to
5f22dbe
Compare
9 tasks
jeryj
changed the title
jeryj
changed the title
jeryj
force-pushed
the
perf/rich-text-typing
branch
from
5f22dbe to
b4f6a77
Compare
jeryj
force-pushed
the
perf/rich-text-typing
branch
from
b4f6a77 to
6258aaa
Compare
Contributor
Author
|
@ellatrix Just ran this once on GitHub CLI, but it's reliably way down locally too. The improvement removes the inserter hover is down 29% and type is down ~ 13% 
|
Member
|
Wait, weren't the code changes here before about a different file (format types), or was that a different PR? |
Member
|
And yes, we shouldn't add separate block editor subscription to rich text... so that makes sense. Could you get a review from whoever added these changes to test? |
Contributor
Author
It was probably this one. I've been playing around with different things trying to figure out the best optimizations, so those were all reverted in favor of removing this subscription.
Yup - on it. Reviews requested from @ockham and @cbravobernal. |
Mamaduka
approved these changes
Oct 23, 2025
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Thanks, @jeryj!
The optimization makes sense. @cbravobernal did something similar last week #72351.
I'll defer on final approval to @cbravobernal and @ockham.
cbravobernal
approved these changes
Oct 23, 2025
Contributor
cbravobernal
left a comment
cbravobernal
left a comment
There was a problem hiding this comment.
Makes totally sense. LGTM.
cbravobernal
added
the
Backport to WP 6.9 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 23, 2025
…72496) Co-authored-by: jeryj <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: ellatrix <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 6fcd212 |
Contributor
|
Thanks folks! And apologies for the performance hit I introduced inadvertently 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes
In #71820 a subscription was added to all RichText components even if there is no block bindings. This caused the inserterHover and type metrics to go up:
#72351 helped address it, but it doesn't seem like the performance improved as significantly as hoped as it did not remove the RichText subscription.
Why?
Any improvements we can make here impact the whole experience.
Excessive subscriptions degrade performance, so we should reduce subscriptions if possible.
How?
Check for the presence of bindable attributes from the PrivateContext instead of settings, so we don't need to add a new subscription. This returns the inserterHover performance metric back to the baseline before #71820.
The current potential win is an early return to avoid adding unnecessary subscriptions for rich-text bindings:
Testing Instructions
There should be no functional changes from trunk.
Testing Instructions for Keyboard
Screenshots or screencast