Notes: Fix the focus transfer issue when switching the sidebars #72486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
commented
Oct 20, 2025
| } = useBlockComments( postId ); | ||
| useEnableFloatingSidebar( resultComments.length > 0 ); | ||
| useEnableFloatingSidebar( | ||
| unresolvedSortedThreads.length > 0 || showCommentBoard |
Member
Author
There was a problem hiding this comment.
Colocated the floating sidebar rendering logic here. The hook will close it automatically if it's no longer enabled.
Mamaduka
added
Backport to WP 6.9 Beta/RC
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +15 B (0%) Total Size: 2.18 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Oct 20, 2025
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
It could use a code check but behaviorwise this feels intuitive on the keyboard for me:
Member
Author
|
Thanks, @jasmussen Bunch of the tests started failing, it could be my changes or core syncing. I'll investigate later. |
t-hamano
approved these changes
Oct 20, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
This is great. I've tried a variety of things, and the focus always moves correctly.
P.S. Do we need both Backport to Gutenberg RC and Backport to WP 6.9 Beta/RC labels?
Member
Author
They're not required, but I thought since the feature also ships with the next Gutenberg, it would be nice to have bugfixes also cherry-picked there. |
Mamaduka
removed
the
Backport to Gutenberg RC
Member
Mamaduka
force-pushed
the
fix/notes-sidebar-refs
branch
2 times, most recently
from
8826e3c to
572c623
Compare
Member
Author
|
I think I found cause for e2e failures. I was accidentally setting complimentary state to I added more safe guard to I would appriciate on final testing to ensure everything is working as expected. Here's logic in question, where gutenberg/packages/interface/src/store/selectors.js Lines 32 to 42 in 1fb8a63 |
|
Flaky tests detected in 9e05b10. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18692493183
|
Member
Author
|
Added an e2e test coverage and will merge once all checks are green again. |
Mamaduka
force-pushed
the
fix/notes-sidebar-refs
branch
from
94076ce to
9b90d54
Compare
Mamaduka
force-pushed
the
fix/notes-sidebar-refs
branch
from
9b90d54 to
9e05b10
Compare
talldan
pushed a commit
that referenced
this pull request
Oct 22, 2025
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: adamsilverstein <[email protected]>
talldan
removed
the
Backport to WP 6.9 Beta/RC
Contributor
|
I've cherry-picked this manually onto the |
ellatrix
pushed a commit
that referenced
this pull request
Oct 22, 2025
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: adamsilverstein <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See: #72431 (comment) and #72157 (comment).
PR fixes a focus transfer bug when adding the first note via the floating sidebar. Because of the condition, the sidebar was mounted too late, and the
commentSidebarRefwasn't available.I've moved the condition, and now it's all handled by the
useEnableFloatingSidebarhook.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2025-10-20.at.15.45.02.mp4