-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Consistently use font-weight 499 instead of 500 #72473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +12 B (0%) Total Size: 2.17 MB
ℹ️ View Unchanged
|
t-hamano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.




Follow up to #70787 (comment)
What?
Updates the
font-weight-mediumvariable in@wordpress/base-stylesfrom 500 to 499.Additionally updates existing
font-weight: 500styles to use this variable.Why?
To ensure a fallback to 400 (instead of 600) when a 400 weight doesn't exist.
I'm thinking we can add a stylelint rule after #71235 is merged.
Testing Instructions
Smoke test some of the affected UIs. Depending on your environment, you will either see no changes, or a 600 weight changed to a 400 weight.