Notes: Add block support note. #72458
Closed
+49
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimotmk
added
the
[Feature] Notes
|
Size Change: +38 B (0%) Total Size: 2.2 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7b85ef4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18607482293
|
t-hamano
reviewed
Oct 18, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Personally, I think the note feature should work for all blocks and shouldn't be a part of the block supports. For example, users might want to add a comment like this to a block:
- The block is broken. Please replace it with a different block.
- Convert this classic block to another block.
Technically, the notes feature should work even with broken or classic blocks.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
Thank you for your review.👍 I also believe it would be better if the notes feature worked across all core blocks.
Is this a bug in the classic or missing blocks? At the moment, the notes feature doesn't work in classic or missing blocks. note.mp4 |
Contributor
This needs to be looked into first. Furthermore, I found that many features don't work in broken blocks, such as locking, renaming, hiding blocks, and notes. These are bugs, so I think they need to either hide the menus in the first place or fix them to work. As for the Classic block, I overlooked the fact that this block doesn't have HTML comments in the first place. Therefore, the notes feature might need to be disabled in Classic blocks. |
Member
|
I agree. Notes should be available for all blocks. The Freefrom/Classic block is an odd one, meant to be a block before content is migrated. |
This was referenced Oct 21, 2025
Contributor
Author
Member
|
Block supports are public API which means anyone can disable the feature for a specific block(s). This isn’t how Notes are supposed to work. P.S. Not everyone editor feature needs to have an associated block support flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add block support note.
Close #72521
Related #54426
Why?
Notes are a very useful feature, but there may be cases where you don't want to add notes to custom blocks.
This maintains consistency with renaming, locking, blockVisibility, etc.
How?
Testing Instructions
note:falseto the supports property of any block'sblock.json.Testing Instructions for Keyboard
Screenshots or screencast
I will add someone who is knowledgeable about Note to the review.