iAPI: Update deprecated usage of data-wp-on-async #72445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 2.18 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2796eb4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18710443901
|
t-hamano
force-pushed
the
iapi-migrate-with-sync-event
branch
from
50495b4 to
f87a988
Compare
7 tasks
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
t-hamano
requested review from
ajitbohra,
fabiankaegy,
nerrad and
ntwb
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
To backport this PR to 6.9, I plan to add |
t-hamano
changed the title
t-hamano
added
the
Backport to WP 6.9 Beta/RC
Contributor
Author
|
@DAreRodz Thanks for the review! |
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9 Editor Tasks
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 22, 2025
* iAPI: Update deprecated usage of data-wp-on-async in core blocks * WIP Co-authored-by: t-hamano <[email protected]> Co-authored-by: DAreRodz <[email protected]>
Contributor
Author
|
The automatic backport to the See #72573 for more details. |
t-hamano
added
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #72413
What?
#72161 deprecates the
data-wp-on-asyncdirective and adds a warning message to replace it withdata-wp-on. This PR replaces thedata-wp-on-asyncdirective in the core blocks withdata-wp-on, wrapping actions inwithSyncEventwhere necessary.Why?
Otherwise, sites with SCRIPT_DEBUG enabled will get a browser warning. I think this should be fixed in the 6.9 cycle.
How?
As I understand it, if we don't access sync properties like
event.currentTargetor sync methods likeevent.preventDefault()orevent.stopPropagination, thenwithSyncEventis unnecessary.I added
withSyncEventonly to actions that access sync properties or methods.Note that this PR does not update the documentation, we should probably update the
wp-on-async,wp-on-async-windwetc. references and add a deprecation note.Testing Instructions
Except for the search block, all block iAPI functionality should be covered by e2e tests, but please test the following: