Merged
Conversation
jeryj
added
[Type] Code Quality
jeryj
commented
Oct 17, 2025
| createBinding( updatedAttributes ); | ||
| } else { | ||
| clearBinding( updatedAttributes ); | ||
| clearBinding(); |
Contributor
Author
There was a problem hiding this comment.
Note that the usage of clearBinding in packages/block-library/src/navigation-link/shared/use-entity-binding.js does not accept any params
Contributor
There was a problem hiding this comment.
There are a couple more in packages/block-library/src/navigation/edit/menu-inspector-controls.js and packages/block-library/src/navigation-submenu/edit.js. We could clean them up here, or in a followup
Contributor
Author
There was a problem hiding this comment.
I had already gotten packages/block-library/src/navigation-submenu/edit.js but missed packages/block-library/src/navigation/edit/menu-inspector-controls.js. Thanks for catching! Fixed it here.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -2 B (0%) Total Size: 2.08 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6ed7d79. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18596761246
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #72165
Cleans up the clearBinding usage. clearBinding doesn't accept any params, yet it was receiving them. Also, it had things in its useEffect dependency array that were not used.
Why?
Code quality
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast