-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Meta: Introduce .mailmap for transforming author names. #72412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 085b50a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19715903838
|
Mamaduka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about .mailmap. Thanks, @dmsnell!
|
It looks like this feature also supports mapping to a preferred email address. I'm wondering if we should map each contributor's I also wonder if we could automate this at all. If the contributor has the email used when committing added as an alias on their account, the commit should be attributed to a user and we can use the w.org API to match with their .org account. That's not a blocker here, but was just thinking of ways to make this easier. |
|
seems like a great idea @desrosj — I have reached out to some people I know to ask which of the four emails they prefer, but automation would help for the overwhelming majority, if people add those aliases. one thing we might run into is that I predict there are significant accounts with no corresponding wordpress.org account. my thinking is that maybe we could do some reasonable effort now to catch things we know about, merge this, then make a blog post on Make and leave a notice on the project README in hopes people see it when they come to the GitHub page. |
To clarify, I'm suggesting that the canonical email used is not the choice of the contributor, but instead always the w.org one that we use in For instances where the user has not connected their w.org account, we could skip the correction of preferred email and just standardize their display name for now. |
7358ab1 to
d192924
Compare
There are numerous cases in this project where a single person has made commits with multiple unique identities. Sometimes this is due to configuration differences on new computers. Sometimes it’s because someone changes their email. Sometimes people change their names. Their digital legacy follows them in `git`. This patch introduces a `.mailmap` file which provides the opportunity to remap names and email addresses across supporting tools to combine or rename those identities. Where available, emails should be the [email protected] address. See `git help mailmap`. This change only impacts how `git` tools display author identities. It includes no code or behavioral changes. Co-authored-by: ajlende <[email protected]> Co-authored-by: desrosj <[email protected]> Co-authored-by: Mamaduka <[email protected]> Github-PR: 72412 Github-PR-URL: #72412
d192924 to
72810a3
Compare
|
@desrosj I like the idea of using Because I wanted to get something out there and establish a precedent, I have done my best to map and remap the top 30 names by commit count via Perhaps we could automate where possible and go from there. |
There are numerous cases in this project where a single person has made commits with multiple unique identities. Sometimes this is due to configuration differences on new computers. Sometimes it’s because someone changes their email. Sometimes people change their names. Their digital legacy follows them in `git`. This patch introduces a `.mailmap` file which provides the opportunity to remap names and email addresses across supporting tools to combine or rename those identities. Where available, emails should be the [email protected] address. See `git help mailmap`. This change only impacts how `git` tools display author identities. It includes no code or behavioral changes. Co-authored-by: ajlende <[email protected]> Co-authored-by: desrosj <[email protected]> Co-authored-by: Mamaduka <[email protected]> Github-PR: 72412 Github-PR-URL: #72412
72810a3 to
4d73481
Compare
|
okay I’ve added more names and tried to catch duplicates where combining them would have a major impact on the commit-count for the individual. there were quite a few where two emails for the same person amounted to more than one hundred commits but each email only had half that associated with it. for these people they have been grossly under-represented in the commit counts because of the spreading of the attribution. I have surely missed many people; perhaps gotten some wrong; hopefully people will review their own accounts and correct them |
There are numerous cases in this project where a single person has made commits with multiple unique identities. Sometimes this is due to configuration differences on new computers. Sometimes it’s because someone changes their email. Sometimes people change their names. Their digital legacy follows them in `git`. This patch introduces a `.mailmap` file which provides the opportunity to remap names and email addresses across supporting tools to combine or rename those identities. Where available, emails should be the [email protected] address. See `git help mailmap`. This change only impacts how `git` tools display author identities. It includes no code or behavioral changes. Co-authored-by: ajlende <[email protected]> Co-authored-by: desrosj <[email protected]> Co-authored-by: Mamaduka <[email protected]> Github-PR: 72412 Github-PR-URL: #72412
4d73481 to
180a1f1
Compare
There are numerous cases in this project where a single person has made commits with multiple unique identities. Sometimes this is due to configuration differences on new computers. Sometimes it’s because someone changes their email. Sometimes people change their names. Their digital legacy follows them in `git`. This patch introduces a `.mailmap` file which provides the opportunity to remap names and email addresses across supporting tools to combine or rename those identities. Where available, emails should be the [email protected] address. See `git help mailmap`. This change only impacts how `git` tools display author identities. It includes no code or behavioral changes. Co-authored-by: ajlende <[email protected]> Co-authored-by: desrosj <[email protected]> Co-authored-by: Mamaduka <[email protected]> Github-PR: 72412 Github-PR-URL: #72412
180a1f1 to
085b50a
Compare
There are numerous cases in this project where a single person has made commits with multiple unique identities. Sometimes this is due to configuration differences on new computers. Sometimes it’s because someone changes their email. Sometimes people change their names. Their digital legacy follows them in `git`. This patch introduces a `.mailmap` file which provides the opportunity to remap names and email addresses across supporting tools to combine or rename those identities. Where available, emails should be the [email protected] address. See `git help mailmap`. This change only impacts how `git` tools display author identities. It includes no code or behavioral changes. Co-authored-by: ajlende <[email protected]> Co-authored-by: desrosj <[email protected]> Co-authored-by: Mamaduka <[email protected]> Github-PR: 72412 Github-PR-URL: WordPress/gutenberg#72412 Source: WordPress/gutenberg@085b50a
See WordPress/wordpress-develop#7180
There are numerous cases in this project where a single person has made commits with multiple unique identities. Sometimes this is due to configuration differences on new computers. Sometimes it’s because someone changes their email. Sometimes people change their names.
Their digital legacy follows them in
git. This patch introduces a.mailmapfile which provides the opportunity to remap names and email addresses across supporting tools to combine or rename those identities.See
git help mailmap.This change only impacts how
gittools display author identities. It includes no code or behavioral changes.Diff from `git shortlog -sne` before and after this change