Direct focus to meta box content on expansion via keyboarding #72372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +290 B (+0.01%) Total Size: 2.08 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c280dad. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18542980335
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related #59246 and #66436
Improves keyboard navigation to the meta boxes from the canvas.
Why?
To improve a11y in relation to the
aria-expandedattribute used on the toggle button because the content that becomes expanded should immediately follow the button in the DOM. That's not an option due the there-resizablelibrary we are using so the next best thing is to move focus into the content upon expansion. Without this it's difficult to find the content that was expanded through keyboarding.How?
Adds focus management to the toggle button (when keyboard activated) and some logic to make the meta boxes wrapping element tabbable when it has overflow. The latter is done in following the precedent from the Preferences modal. Adds some styling to show focus on the meta boxes wrapping element.
Testing Instructions
With at least one meta box active:
Screenshots or screencast
meta-pane-focus-content-difficulty.mp4
meta-pane-focus-content-on-expansion.mp4