DataForm: add new details layout #72355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
|
Size Change: +238 B (+0.01%) Total Size: 2.45 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ea3a652. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19108075127
|
oandregal
changed the title
jorgefilipecosta
force-pushed
the
add/daform-details-layout
branch
from
66d5367 to
432bbd3
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
reviewed
Nov 4, 2025
| ); | ||
| } else { | ||
| // Fall back to the label | ||
| summaryContent = field.label || 'Add more details'; |
Member
There was a problem hiding this comment.
If the summaryField is optional, perhaps just "More details" would be a better fallback given that fields can be read-only (nothing to "add").
Member
|
Direction looks good, thanks for working on this @jorgefilipecosta This PR needs a rebase. The main change is that the |
oandregal
force-pushed
the
add/daform-details-layout
branch
from
432bbd3 to
ea3a652
Compare
oandregal
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
detailslayout type for DataForm that creates collapsible sections using native HTML<details>and<summary>elements.Usage
When a
summaryfield is specified, its rendered value is displayed in the clickable summary (e.g., "Allow comments, Pings enabled"). If not specified, the field's label is used as fallback, if there is no field label we render "Add more details"Changes
DetailsLayoutandNormalizedDetailsLayouttypesFormDetailsFieldcomponent with minimal stylingLayoutDetailsstory to demonstrate usageTesting
View the
LayoutDetailsstory in Storybook under DataViews/DataForm to see the new layout in action with multiple collapsible sections http://localhost:50243/?path=/story/dataviews-dataform--layout-details.