Accordion Header: fixes default styling#72207
Accordion Header: fixes default styling#72207theminaldiwan wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @minaldiwan, @adityaanurag0219. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi @theminaldiwan, can you rebase this PR on top of the trunk branch? In trunk, some fixes and improvements have been made to the Accordion Heading block, so this PR should require fewer additional styles. |
|
Hi @theminaldiwan, in order to solve as many problems as possible, I submitted #73032 instead. I'd like to close this PR, but thanks for your efforts! |
Closes #71529
Why?
In many themes, which they have applying style to button element, But in accordion block button and also heading elements used. Button and heading elements styles is affects to the accordion block.
How?
With the use of minimal styling i have applied to accordion block for themes.
screenshots
Twenty Twenty Five theme
Twenty Twenty One theme
Twenty Twenty theme
Twenty Nineteen theme
Twenty Seventeen theme