Skip to content

Accordion Header: fixes default styling#72207

Closed
theminaldiwan wants to merge 1 commit intoWordPress:trunkfrom
theminaldiwan:fixes/accordion-header-default-styling
Closed

Accordion Header: fixes default styling#72207
theminaldiwan wants to merge 1 commit intoWordPress:trunkfrom
theminaldiwan:fixes/accordion-header-default-styling

Conversation

@theminaldiwan
Copy link
Contributor

Closes #71529

Why?

In many themes, which they have applying style to button element, But in accordion block button and also heading elements used. Button and heading elements styles is affects to the accordion block.

How?

With the use of minimal styling i have applied to accordion block for themes.

screenshots

Twenty Twenty Five theme

Backend Frontend
Twentytwenty-five-backend Twentytwenty-five-frontend

Twenty Twenty One theme

Backend Frontend
Twentytwenty-one-backend Twentytwenty-one-frontend

Twenty Twenty theme

Backend Frontend
Twentytwenty-backend Twentytwenty-frontend

Twenty Nineteen theme

Backend Frontend
Twenty-nineteen-backend Twenty-nineteen-frontend

Twenty Seventeen theme

Backend Frontend
Twenty-seventeen-backend Twenty-seventeen-frontend

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin, New Block.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @minaldiwan, @adityaanurag0219.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: minaldiwan, adityaanurag0219.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: theminaldiwan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Accordion Affects the Accordion Block labels Oct 9, 2025
@t-hamano
Copy link
Contributor

Hi @theminaldiwan, can you rebase this PR on top of the trunk branch?

In trunk, some fixes and improvements have been made to the Accordion Heading block, so this PR should require fewer additional styles.

@t-hamano
Copy link
Contributor

t-hamano commented Nov 6, 2025

Hi @theminaldiwan, in order to solve as many problems as possible, I submitted #73032 instead.

I'd like to close this PR, but thanks for your efforts!

@t-hamano t-hamano closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Accordion Affects the Accordion Block [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accordion Header: Consider defining default style

3 participants